-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added RNN implementation using tf 2.0.md #70
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a nice page, just few minor comments.
Sir @animenon , I guess you need to add |
Sir @animenon you can check now, I have made the changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some markdown rendering issues.
Do check the reference doc, you will probably learn to write good markdown files after this.. maybe you can add a doc how to write markdown too 😄
Now, $O_i$ is, | ||
|
||
> \begin{equation} | ||
O_i = f(X_iW+O_iW') | ||
\end{equation} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be updated.
<div> | ||
<style> | ||
.dataframe tbody tr th:only-of-type { | ||
vertical-align: middle; | ||
} | ||
.dataframe tbody tr th { | ||
vertical-align: top; | ||
} | ||
.dataframe thead th { | ||
text-align: right; | ||
} | ||
</style> | ||
<table border="1" class="dataframe"> | ||
<thead> | ||
<tr style="text-align: right;"> | ||
<th></th> | ||
<th>text</th> | ||
<th>score</th> | ||
</tr> | ||
</thead> | ||
<tbody> | ||
<tr> | ||
<th>0</th> | ||
<td>I have bought several of the Vitality canned d...</td> | ||
<td>5</td> | ||
</tr> | ||
<tr> | ||
<th>1</th> | ||
<td>Product arrived labeled as Jumbo Salted Peanut...</td> | ||
<td>1</td> | ||
</tr> | ||
<tr> | ||
<th>2</th> | ||
<td>This is a confection that has been around a fe...</td> | ||
<td>4</td> | ||
</tr> | ||
<tr> | ||
<th>3</th> | ||
<td>If you are looking for the secret ingredient i...</td> | ||
<td>2</td> | ||
</tr> | ||
<tr> | ||
<th>4</th> | ||
<td>Great taffy at a great price. There was a wid...</td> | ||
<td>5</td> | ||
</tr> | ||
</tbody> | ||
</table> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rewrite these results as markdown tables.
HTML tables may not get rendered correctly.
Refer: Table in .md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@animenon I have a bit confusion, should I pull the changes first then edit the files, and push the changes through the same branch or should I pull the changes and create a new branch and push the changes through a new branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, pull and merge. Then make your changes. No need to create a different branch.
In case you face a conflict, you will have to resolve it.
Don't worry, it will be considered. This repo follows a standard review process hence
I will be approving your PR with |
Pls skip the |
Ok, |
Yes, do a git pull and merge. Then you will have the latest changes from here, after that you can do your changes.
|
@soumya997 be quick so that we can close this in October. |
@animenon I have made some changes please check it here and confirm it's ok or not. |
@soumya997 mostly looks good, just few pyhton blocks seem a little off. |
Was not able to do anything regarding the python code, but used |
I am really very sorry for creating a new branch, I was having some conflicts. |
Hi, @animenon I have added RNN implementation of tf 2.0 in markdown format under ML_AND_DL/tensorflow_2.
issue number #12
Please add
hacktoberfest-accepted
label, nothacktoberfest
before merging 😃.I kept the cell outputs in the doc too.