Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added RNN implementation using tf 2.0.md #70

Closed
wants to merge 4 commits into from

Conversation

soumya997
Copy link
Contributor

Hi, @animenon I have added RNN implementation of tf 2.0 in markdown format under ML_AND_DL/tensorflow_2.
issue number #12
Please add hacktoberfest-accepted label, not hacktoberfest before merging 😃.
I kept the cell outputs in the doc too.

Copy link
Collaborator

@animenon animenon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a nice page, just few minor comments.

ML_and_DL/tensorflow_2/RNN implementation using tf 2.0.md Outdated Show resolved Hide resolved
ML_and_DL/tensorflow_2/RNN implementation using tf 2.0.md Outdated Show resolved Hide resolved
ML_and_DL/tensorflow_2/RNN implementation using tf 2.0.md Outdated Show resolved Hide resolved
ML_and_DL/tensorflow_2/RNN implementation using tf 2.0.md Outdated Show resolved Hide resolved
@soumya997
Copy link
Contributor Author

soumya997 commented Oct 22, 2020

Sir @animenon , I guess you need to add hacktoberfest-accepted label, not hacktoberfest . If it's not hacktoberfest-accepted then my contribution won't be accepted by hacktoberfest. 👈👈👈

@soumya997
Copy link
Contributor Author

Sir @animenon you can check now, I have made the changes

Copy link
Collaborator

@animenon animenon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some markdown rendering issues.

Do check the reference doc, you will probably learn to write good markdown files after this.. maybe you can add a doc how to write markdown too 😄

Comment on lines +46 to +50
Now, $O_i$ is,

> \begin{equation}
O_i = f(X_iW+O_iW')
\end{equation}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be updated.

Comment on lines +197 to +245
<div>
<style>
.dataframe tbody tr th:only-of-type {
vertical-align: middle;
}
.dataframe tbody tr th {
vertical-align: top;
}
.dataframe thead th {
text-align: right;
}
</style>
<table border="1" class="dataframe">
<thead>
<tr style="text-align: right;">
<th></th>
<th>text</th>
<th>score</th>
</tr>
</thead>
<tbody>
<tr>
<th>0</th>
<td>I have bought several of the Vitality canned d...</td>
<td>5</td>
</tr>
<tr>
<th>1</th>
<td>Product arrived labeled as Jumbo Salted Peanut...</td>
<td>1</td>
</tr>
<tr>
<th>2</th>
<td>This is a confection that has been around a fe...</td>
<td>4</td>
</tr>
<tr>
<th>3</th>
<td>If you are looking for the secret ingredient i...</td>
<td>2</td>
</tr>
<tr>
<th>4</th>
<td>Great taffy at a great price. There was a wid...</td>
<td>5</td>
</tr>
</tbody>
</table>
</div>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rewrite these results as markdown tables.
HTML tables may not get rendered correctly.

Refer: Table in .md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@animenon I have a bit confusion, should I pull the changes first then edit the files, and push the changes through the same branch or should I pull the changes and create a new branch and push the changes through a new branch.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, pull and merge. Then make your changes. No need to create a different branch.
In case you face a conflict, you will have to resolve it.

@animenon
Copy link
Collaborator

Sir @animenon , I guess you need to add hacktoberfest-accepted label, not hacktoberfest . If it's not hacktoberfest-accepted then my contribution won't be accepted by hacktoberfest. 👈👈👈

Don't worry, it will be considered.

This repo follows a standard review process hence hacktoberfest is to be used in place of hacktoberfest-accepted.
From the hacktoberfest doc for your reference:

A maintainer can accept your PR by merging it, adding the "hacktoberfest-accepted" label to it, or approving it.

I will be approving your PR with hacktoberfest label and that will be it.

@animenon
Copy link
Collaborator

Sir @animenon you can check now, I have made the changes

Pls skip the Sir. Thanks.

@soumya997
Copy link
Contributor Author

Sir @animenon you can check now, I have made the changes

Pls skip the Sir. Thanks.

Ok,
Actually, I said that because I saw your profile on LinkedIn, and in the future, I also want to build my career in the Data Science field.

@animenon
Copy link
Collaborator

animenon commented Oct 25, 2020 via email

@animenon
Copy link
Collaborator

@soumya997 be quick so that we can close this in October.

@soumya997
Copy link
Contributor Author

@soumya997 be quick so that we can close this in October.

@animenon I have made some changes please check it here and confirm it's ok or not.
If it's ok then I will push the changes.

@animenon
Copy link
Collaborator

@soumya997 mostly looks good, just few pyhton blocks seem a little off.
Also you could use <sup></sup> and <sub></sub> for super script and subscript in the formula.
Anyway push it will, will fix and merge.

@soumya997
Copy link
Contributor Author

@soumya997 mostly looks good, just few pyhton blocks seem a little off.
Also you could use <sup></sup> and <sub></sub> for super script and subscript in the formula.
Anyway push it will, will fix and merge.

Was not able to do anything regarding the python code, but usedsub and sup to adjust the formula.

@soumya997
Copy link
Contributor Author

I am really very sorry for creating a new branch, I was having some conflicts.

@animenon
Copy link
Collaborator

#72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants