Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to pydantic v2 API #13

Merged
merged 3 commits into from
May 16, 2024
Merged

Migrate to pydantic v2 API #13

merged 3 commits into from
May 16, 2024

Conversation

uermel
Copy link
Collaborator

@uermel uermel commented May 16, 2024

Adressing #10

  • Removes tests for pydantic<=2
  • Adds requirement pydantic>=2
  • migrates models in models.py to pydantic v2 API

Depends on PR #12

alisterburt
alisterburt approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@alisterburt alisterburt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks to both of you @uermel and @jojoelfe !!

@alisterburt alisterburt merged commit f597bbc into teamtomo:main May 16, 2024
5 checks passed
@alisterburt
Copy link
Member

deployment going

@alisterburt alisterburt mentioned this pull request May 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisterburt alisterburt alisterburt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uermel @alisterburt