Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow external users from private room #172
Allow external users from private room #172
Changes from 12 commits
60d3517
646236f
4939696
ab07b70
4ed4ec1
1c7be69
e5c1299
d2daaaf
297d01a
1b12112
91c5492
c6bd4ce
a13f852
4da9a40
f07f64a
eccdcef
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pourquoi le default undefined, sachant qu'on a deja
|| {}
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cela permet d'assigner
accessRule
àundefined
sicontentAccessRule
est lui aussi `undefinedSi on enleve
{}
, on peut avoir l'erreur suivante :Error: Cannot read properties of undefined (reading 'rule')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this selecting private rooms only ? So far we were are copying android's implementation for determining what type of room it is :
https://github.com/tchapgouv/tchap-android/blob/develop/vector/src/main/java/fr/gouv/tchap/core/utils/RoomUtils.kt#L31
(selection on isEncrypted and accessRules)
It would be nice to have a utils function (in TchapUtils for example) that checks what type of room it is.
v2 had a isRoomForum function for example, we could do something similar