Allow external users from private room

[mcalinghee]

Allow external users from private room

Create a private room opened to external users(bug fix)

This PR allow external users from a private room but also create a private room opened to external users(fix a small bug)

Before:

1. Create a room opened to externals

2. Settings in v2 : we expect that the room is opened to external => this is not the case here

3. Settings of the room in v4 : we expect that the room is opened to external => this is not the case here

After:

1. Create a room opened to externals

2. Settings in v2 : we expect that the room is opened to external => OK

3. Settings of the room in v4 : we expect that the room is opened to external => OK

[odelcroi]

I guess that we need heavy testing on this PR to approve it or would end to end testing be easy to implement?

[mcalinghee]

I guess that we need heavy testing on this PR to approve it or would end to end testing be easy to implement?

[EDIT] As discussed ,we will look at this later on , we need to check unit test

[estellecomment]

pourquoi le default undefined, sachant qu'on a deja || {} ?

[mcalinghee]

cela permet d'assigner accessRule à undefined si contentAccessRule est lui aussi `undefined

Si on enleve {}, on peut avoir l'erreur suivante : Error: Cannot read properties of undefined (reading 'rule')

[estellecomment]

Is this selecting private rooms only ? So far we were are copying android's implementation for determining what type of room it is :
https://github.com/tchapgouv/tchap-android/blob/develop/vector/src/main/java/fr/gouv/tchap/core/utils/RoomUtils.kt#L31
(selection on isEncrypted and accessRules)

It would be nice to have a utils function (in TchapUtils for example) that checks what type of room it is.
v2 had a isRoomForum function for example, we could do something similar

[estellecomment]

I cannot invite externs. I get a silent fail, nothing happens.

Running locally, with prod backend, after a clearing of node_modules and rebuild :
Error in console : t is undefined. Happens here : https://github.com/matrix-org/matrix-react-sdk/blob/68b3fd78c2759b6b1c6de6f86c93a3e021db36ec/src/components/views/dialogs/InviteDialog.tsx#L929-L930

Reproduce : create a room (with or without externs). Invite an extern by email.
Same thing happens whether the extern account exists already or not.

Edit : I will try testing on the review app tomorrow, in case it is a local problem. (will move review app to prod backend for testing)

[estellecomment]

Missing translation in french :

[mcalinghee]

Missing translation in french :

Translation was added

[estellecomment]

(closing and reopening PR to trigger the review app, it had been deleted from lack of activity)

[estellecomment]

When testing with my account, on prod backend, it works when you paste the email, rather than type it.
Works with externs who already have an account, or not.

There are issues, unrelated to this PR, with :

• when you type the email and press enter or space, the invite dialog crashes.
• inviting fails sometimes because of a 403 on GET https://matrix.agent.dinum.tchap.gouv.fr/_matrix/identity/v2/terms. This is the client trying to get the user to approve the terms and conditions of the identity server. This should not be happening, terms in Tchap do not need to be approved. Seen on a user created in v2 but only used in v4.

Will file separate issues.

So, testing passes !

[estellecomment]

Other issue :

• in a room without externs, the toggle appears disabled, when actually it does work.
  

• when the toggle is disabled, there is no explanation about why.

I'll look into them now.

[estellecomment]

About the disabled toggle : it's actually fine.
It's just that the color for a toggle that's enabled and off is grey (which I associate with disabled). It's consistent with the rest of the app.

[estellecomment]

For the extra info, it's complicated to add because the toggle is part of the "Public" radiobutton description.
We should move it out of the "Public" radiobutton.
Not doing in this PR.