Update @orbit/records dependency to latest beta #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0.17.0-beta.19 introduced breaking changes: https://github.com/orbitjs/orbit/releases/tag/v0.17.0-beta.19 This has build failure in `sql-source-legacy-test` that I commented out; I’m not sure how important it is given the file name.
backspace
added a commit
to backspace/koa-orbit
that referenced
this pull request
Sep 24, 2021
This is a followup to this PR: tchak/orbit-sql#8 I needed to use the code from that branch (and with the not-building test removed). This seems pretty straightforward; `UnknownSerializer` is no longer needed because `Serializer` can be used directly: orbitjs/orbit#837 I chose to rename the two deserialising functions to remove the QB that was also removed from the imported class names.
tchak
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.17.0-beta.19 introduced breaking changes, this updates to handle that
Query.expressionscan beRecordQueryExpression | RecordQueryExpression[]. Without it, I was gettingquery.expressions is not iterableerrors. I chose to make the dependency exact instead of^because there could be further breaking changes in the 0.17 cycle and I struggled to getresolutionsand/ornohoistworking to override it for just the project that was consuming this in a monorepo.This has Typescript failure in
sql-source-legacy-test.tsthat I commented out; I’m not sure how important it is given the file name, but if you have a suggestion about how it could be fixed, let me know!Thanks for your work on this (and
koa-orbit, which I may need to make a parallel PR for), it’s helped me get started with an Orbit project more easily.