Skip to content

Conversation

backspace
Copy link

This is a followup to this PR. I needed to use the code from that branch (and with the not-building test removed).

This seems pretty straightforward; UnknownSerializer is no longer needed because Serializer can be used directly. I chose to rename the two deserialising functions to remove the QB that was also removed from the imported class names.

(How can I get the tests to run? 🤔 They pass locally)

This is a followup to this PR:
tchak/orbit-sql#8

I needed to use the code from that branch (and with the
not-building test removed).

This seems pretty straightforward; `UnknownSerializer` is
no longer needed because `Serializer` can be used directly:
orbitjs/orbit#837

I chose to rename the two deserialising functions to remove
the QB that was also removed from the imported class names.
@backspace
Copy link
Author

backspace commented Sep 24, 2021

When I use this and the orbit-sql PR in the orbit-server-template I cloned I get 404 for all endpoints, so maybe there’s something wrong… I’ll hopefully be able to dig into this this weekend. Disregard I had an incorrect dependency in package.json that I added while struggling with monorepo problems 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant