Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporal: Tests for week-numbering algorithm #4009

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

Aditi-1400
Copy link
Contributor

Adds and updates tests for PR: tc39/proposal-temporal#2756

@Aditi-1400 Aditi-1400 requested a review from a team as a code owner February 15, 2024 17:59
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! All these tests look good, with one comment about needing to move a few of them.

However I think we need to cover a few more things in order to make sure that engines implement every aspect of this normative change:

  • In test/built-ins/, validation that a custom calendar may return undefined from yearOfWeek and weekOfYear and that a PlainDate/PlainDateTime/ZonedDateTime with this custom calendar will have the yearOfWeek/weekOfYear property with the value of undefined
  • In test/intl402/, a sample case where iso8601 and gregory week numbers disagree according to CLDR

I'm happy to merge this after moving those two tests and add the additional coverage in a follow up, or also happy to re-review this with the additional tests added. Let me know what your preference is.

@Aditi-1400 Aditi-1400 force-pushed the temporal-2744 branch 2 times, most recently from 30a24e9 to 4ba2a79 Compare February 21, 2024 14:03
@Aditi-1400
Copy link
Contributor Author

Thanks! All these tests look good, with one comment about needing to move a few of them.

However I think we need to cover a few more things in order to make sure that engines implement every aspect of this normative change:

  • In test/built-ins/, validation that a custom calendar may return undefined from yearOfWeek and weekOfYear and that a PlainDate/PlainDateTime/ZonedDateTime with this custom calendar will have the yearOfWeek/weekOfYear property with the value of undefined
  • In test/intl402/, a sample case where iso8601 and gregory week numbers disagree according to CLDR

I'm happy to merge this after moving those two tests and add the additional coverage in a follow up, or also happy to re-review this with the additional tests added. Let me know what your preference is.

I've updated the PR to add the tests you requested.

Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, all looks good!

@ptomato ptomato merged commit 0fd1675 into tc39:main Feb 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants