-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normative: Make CalendarDateWeekOfYear return undefined #2756
Conversation
3cc39bb
to
c7a384c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2756 +/- ##
==========================================
+ Coverage 96.56% 96.61% +0.04%
==========================================
Files 23 23
Lines 12277 12309 +32
Branches 2271 2271
==========================================
+ Hits 11855 11892 +37
+ Misses 360 355 -5
Partials 62 62 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After initially reviewing this I thought of something else that needs to be done. We should change CalendarWeekOfYear and CalendarYearOfWeek so that a custom calendar's weekOfYear
and yearOfWeek
method can return undefined. (Similar to what we do in CalendarEra and CalendarEraYear.) This is also something we could write test262 tests for.
41db8dc
to
01a7d8d
Compare
01a7d8d
to
dd62683
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks!
dd62683
to
cd78e34
Compare
cd78e34
to
23ce55c
Compare
...for all calendars without well-defined week calendar system
23ce55c
to
f5b3edb
Compare
This normative change reached consensus in the 2023-02 TC39 plenary meeting. I've updated this PR to include the test262 tests that I've just merged. |
Make
CalendarDateWeekOfYear
return undefined for all calendars without well-defined week calendar systemFixes: #2744