Generate multiple signing sets, create signing set IDs #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewstone
reviewed
Jul 14, 2023
added 2 commits
July 17, 2023 10:18
|
Partially completed: tangle-network/tangle#207 |
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #680 +/- ##
==========================================
- Coverage 16.03% 15.80% -0.22%
==========================================
Files 73 76 +3
Lines 5436 5514 +78
==========================================
Hits 871 871
- Misses 4565 4643 +78
☔ View full report in Codecov by Sentry. |
1xstj
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to increase the probability that signing a proposal succeeds in the event a signer drops off in a signing set, we now spawn 2 signing sets per unsigned proposal. Before SigningManagerV2, we did something similar, except, we did so in response to messages going missing. Now that messages are no longer mysteriously dropping, so long as nodes stay online and are non-malicious, we increase the probability that we converge toward signing completion.