Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Signing requires all authorities to be online #679

Closed
1xstj opened this issue Jul 14, 2023 · 0 comments · Fixed by #680
Closed

[BUG] Signing requires all authorities to be online #679

1xstj opened this issue Jul 14, 2023 · 0 comments · Fixed by #680
Assignees
Labels
bug 🪲 Something isn't working p0 🔥 Critical issues that need to be resolved immediately

Comments

@1xstj
Copy link
Contributor

1xstj commented Jul 14, 2023

Describe the bug
Consider a DKG network with t=3 and n=5. Ideally if one of the nodes crashes/does not respond, the signing should progress since we still have t+1 (4) authorities online and signing.

To Reproduce
Steps to reproduce the behavior:

  1. Start a local network with 3-of-5 authorities
  2. Wait until the genesis keygen is completed and atleast one proposal is signed
  3. Kill one of the authority nodes, the network should have 4-of-5 authorities now
  4. Block production continues, but any proposals send to the DKG are not signed.

Expected behaviour
Proposals are signed as long as t+1 authorities are online.

@1xstj 1xstj added bug 🪲 Something isn't working p0 🔥 Critical issues that need to be resolved immediately labels Jul 14, 2023
@1xstj 1xstj changed the title [BUG] Signing requires all authorities to function [BUG] Signing requires all authorities to be online Jul 14, 2023
@1xstj 1xstj linked a pull request Jul 14, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working p0 🔥 Critical issues that need to be resolved immediately
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants