Add optional TLS spec for RouteGroups #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The optional TLS spec will allow per-host TLS termination using Kubernetes secrets.
|
@rickhlx will check this as soon zalando/skipper#2814 is merged. |
|
LGTM, will merge after we land zalando/skipper#2814 (please update CRD there) |
AlexanderYastrebov
added a commit
that referenced
this pull request
Mar 26, 2024
controller-gen does not support validating internal list items on list types, see kubernetes-sigs/controller-tools#342 To add host pattern we used perl hack that is hard to extend to multiple validations. Also #16 added optional tls spec that contains hosts field for which perl hack worked by accident, see #16 (comment) This change replaces perl hack for a go hack and adds max length constraint. Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
that referenced
this pull request
Mar 26, 2024
controller-gen does not support validating internal list items on list types, see kubernetes-sigs/controller-tools#342 To add host pattern we used perl hack that is hard to extend to multiple validations. Also #16 added optional tls spec that contains hosts field for which perl hack worked by accident, see #16 (comment) This change replaces perl hack for a go hack and adds max length constraint. Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow Skipper to add TLS certs defined in RouteGroups to the certificate registry which will be used to terminate TLS based on the configured hostnames. This behaviors mimics Ingress Spec.