Skip to content

Check entire buffer in check overflow #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jserv merged 7 commits into from
Feb 24, 2019
Merged

Check entire buffer in check overflow #7

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2456a84
Check entire buffer in check overflow
cjwind Feb 23, 2019
1e67366
Move scope of i into for loop
cjwind Feb 23, 2019
38a6ee0
Add description of validate memory algorithm
cjwind Feb 23, 2019
ba07749
Indent comment
cjwind Feb 23, 2019
b519b1b
Refine overflow check implementation
cjwind Feb 23, 2019
28fe8f0
Add parentheses to while
cjwind Feb 23, 2019
f4467b3
Refine comment
cjwind Feb 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion qtest.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,18 @@ bool do_remove_head(int argc, char *argv[])
if (removes[0] == '\0') {
report(1, "ERROR: Failed to store removed value");
ok = false;
} else if (removes[string_length + 1] != 'X') {
}

bool check_overflow = true;
Copy link
Contributor

@jserv jserv Feb 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder the necessity of variable check_overflow. Can you eliminate it by replacing for with while?

int i = 0;
Copy link
Contributor

@jserv jserv Feb 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the scope of int i into for-loop. So, it would look like the following:

for (int i = string_length + 1; i < string_length + STRINGPAD; i++) {
    ...

for (i = string_length + 1; i < string_length + STRINGPAD; i++) {
Copy link
Contributor

@jserv jserv Feb 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the algorithm descriptions about checking and validating memory here.

if (removes[i] != 'X') {
check_overflow = false;
break;
}
}

if (!check_overflow) {
report(1,
"ERROR: copying of string in remove_head overflowed "
"destination buffer.");
Expand Down