Check entire buffer in check overflow #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
do_remove_head() checked removes[string_length + 1] only, so q_remove_head() would pass the test when it try to write data to other place in the buffer, such as index string_length + 2. Check entire buffer to fix it.
jserv
reviewed
Feb 23, 2019
qtest.c
Outdated
| } | ||
|
|
||
| bool check_overflow = true; | ||
| int i = 0; |
Contributor
There was a problem hiding this comment.
Move the scope of int i into for-loop. So, it would look like the following:
for (int i = string_length + 1; i < string_length + STRINGPAD; i++) {
...
jserv
reviewed
Feb 23, 2019
qtest.c
Outdated
|
|
||
| bool check_overflow = true; | ||
| int i = 0; | ||
| for (i = string_length + 1; i < string_length + STRINGPAD; i++) { |
Contributor
There was a problem hiding this comment.
Add the algorithm descriptions about checking and validating memory here.
jserv
reviewed
Feb 23, 2019
| } else if (removes[string_length + 1] != 'X') { | ||
| } | ||
|
|
||
| /* |
Contributor
There was a problem hiding this comment.
Tweak the indention for comments.
Something like:
/*
How large is a queue before it's considered big.
This affects how it gets printed
and whether cautious mode is used when freeing the list
*/
jserv
reviewed
Feb 23, 2019
qtest.c
Outdated
| Validate memory by checking removes's padding positions are still | ||
| initial value 'X'. | ||
| */ | ||
| bool check_overflow = true; |
Contributor
There was a problem hiding this comment.
I wonder the necessity of variable check_overflow. Can you eliminate it by replacing for with while?
Variable check_overflow isn't necessary.
jserv
reviewed
Feb 23, 2019
qtest.c
Outdated
| break; | ||
| } | ||
| int i = string_length + 1; | ||
| while (i < string_length + STRINGPAD && removes[i] == 'X') { |
Contributor
There was a problem hiding this comment.
Add parentheses. So, it becomes while ((i < string_length + STRINGPAD) && removes[i] == 'X') {
jserv
reviewed
Feb 23, 2019
qtest.c
Outdated
| } | ||
|
|
||
| /* | ||
| Validate memory by checking removes's padding positions are still |
Contributor
There was a problem hiding this comment.
Check for grammar within the comment.
threesmaller
pushed a commit
to threesmaller/lab0-c
that referenced
this pull request
Feb 24, 2019
do_remove_head() checked removes[string_length + 1] only, so q_remove_head() would unexpectedly pass the test when it attempts to write data to other place in the buffer, such as index string_length + 2. Check entire buffer to fix it.
tfliao
added a commit
to tfliao/lab0-c
that referenced
this pull request
Feb 28, 2019
- Test sysprog21#7 still failed, leave it for investigate - Match swp file in .gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do_remove_head() checked removes[string_length + 1] only, so
q_remove_head() would pass the test when it try to write data to other
place in the buffer, such as index string_length + 2. Check entire
buffer to fix it.