Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): remove exit app buttons #2206

Merged
merged 1 commit into from
Sep 6, 2024
Merged

fix(ui): remove exit app buttons #2206

merged 1 commit into from
Sep 6, 2024

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented Sep 6, 2024

Description

Exiting programmatically is not really possible on iOS. react-native-exit-app makes the app crash intentionally, and the user will be presented with a crash dialog, which is bad UX.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

Copy link

socket-security bot commented Sep 6, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/iterator.prototype@1.1.2 None 0 10.1 kB ljharb

🚮 Removed packages: npm/react-native-exit-app@2.0.0)

View full report↗︎

@pwltr pwltr mentioned this pull request Sep 6, 2024
7 tasks
@pwltr pwltr force-pushed the chore/remove-exit-app branch from ecc01cd to dfd2f84 Compare September 6, 2024 11:05
@pwltr pwltr requested a review from limpbrains as a code owner September 6, 2024 11:05
@pwltr pwltr merged commit 3745f1d into master Sep 6, 2024
7 checks passed
@pwltr pwltr deleted the chore/remove-exit-app branch September 6, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants