Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove exit & restart #2086

Closed
wants to merge 1 commit into from
Closed

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented Jul 23, 2024

Description

Exiting programmatically is not really possible on iOS. The libraries we are using make the app crash intentionally, and the user will be presented with a crash dialog, which is bad UX. I'm removing exit and restart functionality and updating tests to use the UI to wipe the app.

Also removes some unused javascript dependencies.

Linked Issues/Tasks

Closes #1922

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

QA Notes

Check that the app is always wiped completely when using reset UI.

@pwltr pwltr requested a review from limpbrains as a code owner July 23, 2024 09:35
Copy link

socket-security bot commented Jul 23, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/array-buffer-byte-length@1.0.0 None 0 8.05 kB ljharb
npm/array-union@2.1.0 None 0 3.17 kB sindresorhus
npm/array.prototype.flat@1.3.2 None 0 18.7 kB ljharb
npm/arraybuffer.prototype.slice@1.0.2 None 0 19.4 kB ljharb
npm/cliui@8.0.1 None 0 32.3 kB oss-bot
npm/dir-glob@3.0.1 None 0 5.42 kB sindresorhus
npm/es-to-primitive@1.2.1 None 0 40.4 kB ljharb
npm/esrecurse@4.3.0 None 0 13.5 kB michaelficarra
npm/function.prototype.name@1.1.6 None 0 25.5 kB ljharb
npm/get-symbol-description@1.0.0 None 0 10.3 kB ljharb
npm/hasown@2.0.0 None 0 10.8 kB ljharb
npm/make-dir@2.1.0 filesystem 0 9.2 kB sindresorhus
npm/mime@2.6.0 None 0 60.1 kB broofa
npm/object-keys@1.1.1 None 0 26.5 kB ljharb
npm/object.assign@4.1.4 None 0 1.17 MB ljharb
npm/p-try@2.2.0 None 0 4.37 kB sindresorhus
npm/pify@4.0.1 None 0 7.23 kB sindresorhus
npm/regexp.prototype.flags@1.5.1 None 0 39 kB ljharb
npm/safe-array-concat@1.0.1 None 0 11.9 kB ljharb
npm/set-function-name@2.0.1 None 0 10.1 kB ljharb
npm/yargs-parser@21.1.1 environment, filesystem 0 128 kB oss-bot
npm/yargs@17.7.2 environment, filesystem 0 292 kB oss-bot

🚮 Removed packages: npm/@bcoe/v8-coverage@0.2.3, npm/@istanbuljs/schema@0.1.3, npm/brittle@3.2.1, npm/c8@7.13.0, npm/cliui@7.0.4, npm/html-escaper@2.0.2, npm/istanbul-lib-coverage@3.2.0, npm/istanbul-lib-report@3.0.0, npm/istanbul-reports@3.1.5, npm/make-dir@3.1.0, npm/mime@3.0.0, npm/queue-tick@1.0.1, npm/random-access-storage@2.3.0, npm/random-access-web-storage@2.0.0, npm/react-native-exit-app@2.0.0, npm/react-native-restart@0.0.27, npm/same-object@1.0.2, npm/test-exclude@6.0.0, npm/tmatch@5.0.0, npm/v8-to-istanbul@9.1.0, npm/yargs-parser@20.2.9, npm/yargs@16.2.0

View full report↗︎

@pwltr pwltr force-pushed the chore/remove-exit-restart branch from 930c598 to f218c0c Compare July 23, 2024 09:37
@pwltr pwltr self-assigned this Jul 23, 2024
@pwltr pwltr force-pushed the chore/remove-exit-restart branch from f218c0c to 92b4b97 Compare July 23, 2024 10:37
@limpbrains
Copy link
Collaborator

limpbrains commented Jul 23, 2024

@coreyphillips @Jasonvdb can you please also take a look at this?
I worry that user might tap Wipe while some beignet/LDK async function is running and it might mutate the state.
Maybe we should keep react-native-restart ?

And we should probably aim for the next sprint

@Jasonvdb
Copy link
Collaborator

For LDK as long as the node it stopped before wiping it is fine

@limpbrains
Copy link
Collaborator

ios e2e test is failing

@pwltr
Copy link
Collaborator Author

pwltr commented Sep 6, 2024

We can't remove react-native-restart yet, related: #2206

@pwltr pwltr closed this Sep 6, 2024
@pwltr pwltr deleted the chore/remove-exit-restart branch September 6, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug/iOS]: Crash after resetting wallet
3 participants