-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove exit & restart #2086
Conversation
930c598
to
f218c0c
Compare
f218c0c
to
92b4b97
Compare
@coreyphillips @Jasonvdb can you please also take a look at this? And we should probably aim for the next sprint |
For LDK as long as the node it stopped before wiping it is fine |
ios e2e test is failing |
We can't remove |
Description
Exiting programmatically is not really possible on iOS. The libraries we are using make the app crash intentionally, and the user will be presented with a crash dialog, which is bad UX. I'm removing exit and restart functionality and updating tests to use the UI to wipe the app.
Also removes some unused javascript dependencies.
Linked Issues/Tasks
Closes #1922
Type of change
Tests
QA Notes
Check that the app is always wiped completely when using reset UI.