Fix Max Fee Checks #1732
Merged
Fix Max Fee Checks #1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents user from selecting or setting a fee-rate above what the max is. Resolves UI bug in #1619
limpbrains
requested changes
Apr 25, 2024
Revert maxLength to 3 in FeeCustom.tsx.
limpbrains
approved these changes
Apr 25, 2024
|
Verified in v118 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FeeRate&FeeCustomviews to prevent users from selecting or setting a fee-rate above what the max is.getFeeInfomethod.Linked Issues/Tasks
Type of change
Tests
QA Notes
When setting fees during the send flow, the max fee checks should be in place and prevent you from setting a value above the
maxFeeprovided by Beignet'sgetFeeInfomethod.