Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Fees indication #1619

Closed
JeanlChristophe opened this issue Mar 27, 2024 · 5 comments
Closed

[Bug]: Fees indication #1619

JeanlChristophe opened this issue Mar 27, 2024 · 5 comments
Assignees
Labels
bug Something isn't working triage This issue needs to be looked over by the team

Comments

@JeanlChristophe
Copy link

Describe the bug

I'm trying to make an onchain transaction of 10,000 sats, and it says that the fees will be $0.15, but when I continue, the correct fees are charged.

Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Screenshots / Recording

screen-20240327-143554.mp4

Operating system

GrapheneOS

Bitkit version

v111

Log output

No response

@JeanlChristophe JeanlChristophe added bug Something isn't working triage This issue needs to be looked over by the team labels Mar 27, 2024
@coreyphillips
Copy link
Collaborator

To reproduce:

  • Create a transaction for 5000 sats.
  • Tap "Continue". In a high fee environment the fee should get set to "Custom" at a lower sat per vByte.
  • Navigate Back.
  • Tap "Continue" again without adjusting the sat amount.
  • Observe that "Custom" is now "Normal", but at the same fee rate.

@catch-21
Copy link
Contributor

I currently see $0.11, which appears to be the value for 1sat/vB. For some reason it displays the custom value which defaults to 1sat/vB.

coreyphillips added a commit that referenced this issue Apr 25, 2024
Prevents user from selecting or setting a fee-rate above what the max is.
Resolves UI bug in #1619
@coreyphillips coreyphillips mentioned this issue Apr 25, 2024
2 tasks
pwltr pushed a commit that referenced this issue Apr 25, 2024
Prevents user from selecting or setting a fee-rate above what the max is.
Resolves UI bug in #1619
@catch-21
Copy link
Contributor

Tested on 658b9f2
I'm no longer able to reproduce the original issue 👍
I am seeing what JC described in their last comment, 'Normal' when it should be 'Custom' 👎 see vid:

Screenrecorder-2024-05-21-17-14-46-555.2.mp4

Current fees are Slow=5 Normal=18 Fast=21

@coreyphillips Do you consider this related here or a separate UI bug?

@coreyphillips
Copy link
Collaborator

This would be a new issue.

@catch-21
Copy link
Contributor

Raised #1896

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage This issue needs to be looked over by the team
Projects
None yet
Development

No branches or pull requests

3 participants