feat(rfq-relayer): regenerate with updated fastbridgev2 and zap terminology [SLT-442] #3393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* dispute emit relayer not guard. new Claim/Refund transfer & tests [SLT-295] * var & comment tweaks
* Explorer maintenance banner message
* Feat: check amounts with offsets in isProfitable() * WIP: test adj changes * Fix: quoter tests * [goreleaser] * Cleanup: lint * Feat: move origin offset calc to getDestAmount() * Feat: add more test cases for new offset logic * [goreleaser] * Fix: offset application * [goreleaser]
Co-authored-by: Trajan0x <trajan0x@users.noreply.github.com>
* storage refs - readability & gas impv * rearrange reads on dispute * read storage to local stack - claim * docs: make storage writes more explicit --------- Co-authored-by: ChiTimesChi <88190723+ChiTimesChi@users.noreply.github.com>
…g [SLT-328] [SLT-273] (#3284) * refactor: isolate encoding into a separate lib * test: use library encoding in tests * feat: add new encoding/decoding * test: prove/claim/refund/relay with invalid request payloads * feat: use new full struct encoding/decoding * feat: decode relevant fields only in claim * feat: decode relevant fields only in relay * feat: decode relevant fields only in refund * refactor: improve constants readability a-la Go * docs: validate/encode/decode V2 * test: rework to remove extra contracts from gas report * fix: change V2 fields encoding order
* inherit MulticallTarget to FastBridge V1 * test: simple integration tests for multicall in V1 * refactor: make integration test more generic --------- Co-authored-by: parodime <jordan@protochainresearch.com>
…3304) * build: add OZ contracts 4.5.0 * build: fix openzeppelin nohoist, yarn * chore: move legacy router contracts from the old repo * build: add legacy contracts to fmt, solhint exceptions * test: add FB RouterV2 integration tests * test: override edge case scenarios handled by Router * build: ignore legacy contract in slither * ci: add optional coverage filter step * ci: install lcov in Foundry Coverage job * build: try fixing slither filter paths * Revert "build: try fixing slither filter paths" This reverts commit 118103e. * ci: add slither-config path
…Q transaction has been refunded [SLT-350] (#3307) * Returns bridge refunds with status * Remove error details that are already contained in logs * updates docs for fields * Adds try catch and return null for non-RFQ in-flight txns * dry graphql construction & queries
…ridgemap with destinations (#3314)
* Chain updates * re-gen bridge map * Normalize for USDC.e on RFQ * Polygon pol/matic routeSymbol adjustment --------- Co-authored-by: aureliusbtc <82057759+aureliusbtc@users.noreply.github.com>
* Re-gen bridge map * Pol updates --------- Co-authored-by: aureliusbtc <82057759+aureliusbtc@users.noreply.github.com>
* Updates bridgeMap * Pol updates --------- Co-authored-by: aureliusbtc <82057759+aureliusbtc@users.noreply.github.com>
* uptime metrics * update --------- Co-authored-by: Trajan0x <trajan0x@users.noreply.github.com>
…icit docs [SLT-342] (#3316) * refactor: emit the events before external calls * docs: storage reads * docs: more explicit notes about tx status changes * docs: inheritdoc * docs: update permisionless claim phrasing Co-authored-by: parodime <jordan@protochainresearch.com> --------- Co-authored-by: parodime <jordan@protochainresearch.com>
dwasse
requested review from
trajan0x,
aureliusbtc and
ChiTimesChi
as code owners
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 184 files out of 280 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the WalkthroughThe pull request introduces significant updates across multiple packages, primarily transitioning from the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
dwasse
requested review from
bigboydiamonds,
abtestingalpha and
Defi-Moses
as code owners
github-actions
bot
added
M-ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/relayer-arb-call #3393 +/- ##
===============================================================
+ Coverage 24.99061% 31.08355% +6.09293%
===============================================================
Files 207 560 +353
Lines 13317 38300 +24983
Branches 82 82
===============================================================
+ Hits 3328 11905 +8577
- Misses 9701 25362 +15661
- Partials 288 1033 +745
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -1,5 +1,5 @@ | |||
| // SPDX-License-Identifier: MIT | |||
| pragma solidity ^0.8.20; | |||
| pragma solidity ^0.8.4; | |||
Check warning
Code scanning / Slither
Incorrect versions of Solidity Warning
| @@ -1,5 +1,5 @@ | |||
| // SPDX-License-Identifier: MIT | |||
| pragma solidity ^0.8.20; | |||
| pragma solidity ^0.8.4; | |||
Check warning
Code scanning / Slither
Incorrect versions of Solidity Warning
Comment on lines
+227
to
+232
| function zapNative(bytes calldata encodedTx) internal pure returns (uint256 zapNative_) { | ||
| // Load 32 bytes from the offset. No shift is applied, as we need the full 256 bits. | ||
| assembly { | ||
| zapNative_ := calldataload(add(encodedTx.offset, OFFSET_ZAP_NATIVE)) | ||
| } | ||
| } |
Check warning
Code scanning / Slither
Assembly usage Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
fastbridgev2contract version with enhanced functionality.RecipientMock.Bug Fixes
Documentation
Tests
fastbridgev2contract and updated existing tests to accommodate changes in the contract interface.