ci: disable Solidity workflows for PRs into fe-release

[ChiTimesChi]

Description
A clear and concise description of the features you're adding in this pull request.

Additional context
Add any other context about the problem you're solving.

Metadata

• Fixes #[Link to Issue]

Summary by CodeRabbit

• Chores
  • Updated workflow configurations to enhance control over job executions based on branch and package modifications.
  • Introduced a branch exclusion rule for pull requests to prevent the fe-release branch from triggering specific workflows.
  • Refined conditions for running jobs related to slither, gas-diff, coverage, and size-check.

[coderabbitai]

Walkthrough

The changes in the .github/workflows/solidity.yml file introduce a branch exclusion rule for pull requests, specifically excluding the fe-release branch from triggering Solidity workflows. Additionally, job definitions for slither, gas-diff, coverage, and size-check have been modified to include conditional logic based on the outputs of the changes job. These jobs will only run if certain conditions regarding package modifications are met. The cancel-outdated job remains unchanged in structure.

Changes

File Path	Change Summary
.github/workflows/solidity.yml	Added branch exclusion for fe-release in the pull_request trigger. Updated job definitions for slither, gas-diff, coverage, and size-check to include conditional execution based on package_count and packages outputs. cancel-outdated job structure remains unchanged.

Possibly related PRs

• ci: Solidity gas diff [SLT-259] #3181: Modifies the .github/workflows/solidity.yml file to enhance the CI workflow for Solidity packages, aligning with the main PR's focus on refining job definitions and conditions.
• ci: solidity gas diff options [SLT-267] #3193: Updates the .github/workflows/solidity.yml file, adding parameters to the gas diff action, relevant to the main PR's changes in job execution logic and conditions.
• ci: fix matrix exclude for solidity packages #3255: Addresses exclusion logic for the solidity-devops package in the CI workflow, directly relating to the main PR's updates on job execution conditions.
• ci: matrix package exclude #3257: Modifies conditions for job execution in the CI workflow regarding the solidity-devops package, relevant to the main PR's focus on enhancing control flow based on package changes.

Suggested labels

M-ci, size/xs

Suggested reviewers

• aureliusbtc
• trajan0x

🐰 In the meadow, where code does flow,
A branch was excluded, to keep it aglow.
Jobs now run smart, with conditions so bright,
Only when needed, they spring into flight.
Hooray for the changes, let’s hop with delight! 🌼

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between a96f2f7 and e9a74ea.

📒 Files selected for processing (1)

• .github/workflows/solidity.yml (1 hunks)

🧰 Additional context used

🔇 Additional comments (5)

.github/workflows/solidity.yml (5)

10-12: LGTM: Branch exclusion for fe-release implemented correctly.

The addition of the branch exclusion rule for fe-release in the pull_request trigger successfully implements the PR objective. This change will prevent Solidity workflows from running on pull requests targeting the fe-release branch, which is the intended behavior.

---

Line range hint 131-132: LGTM: Slither job condition refined.

The added conditional logic for the slither job is well-implemented. It ensures that the job only runs when relevant packages are modified (package_count > 0) and excludes the solidity-devops package. This optimization aligns with the workflow's purpose and improves efficiency.

---

Line range hint 236-242: LGTM: Gas-diff job condition and matrix strategy updated correctly.

The modifications to the gas-diff job are well-implemented:

1. The conditional logic ensures the job only runs when relevant packages are modified.
2. The exclusion of solidity-devops from the matrix strategy is appropriate, as it contains only devops scripts.

These changes optimize the workflow by preventing unnecessary job runs for irrelevant changes or packages.

---

Line range hint 285-291: LGTM: Size-check job condition and matrix strategy updated appropriately.

The changes to the size-check job are well-implemented and consistent with the modifications in other jobs:

1. The conditional logic ensures the job runs only for relevant package modifications.
2. The exclusion of solidity-devops from the matrix strategy is appropriate for a contract size check.

These updates contribute to the overall optimization of the workflow by preventing unnecessary job executions.

---

Line range hint 1-314: Overall assessment: Well-implemented workflow optimizations.

The changes in this file successfully achieve the PR objective of disabling Solidity workflows for PRs into the fe-release branch. Additionally, the modifications to job conditions and matrix strategies across multiple jobs (slither, gas-diff, and size-check) optimize the workflow by:

1. Ensuring jobs only run when relevant packages are modified.
2. Excluding the solidity-devops package from unnecessary checks.

These improvements enhance the efficiency of the CI/CD pipeline by reducing unnecessary job executions while maintaining the integrity of the Solidity-related checks for relevant changes.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[cloudflare-workers-and-pages]

Deploying sanguine-fe with    Cloudflare Pages

Latest commit:	e9a74ea
Status:	✅  Deploy successful!
Preview URL:	https://fa3c73e8.sanguine-fe.pages.dev
Branch Preview URL:	https://ci-fe-release-solidity-disab.sanguine-fe.pages.dev

View logs