Skip to content

[ux.symfony.com] Fix rendering/color issues on Map page #2069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2024
Merged

[ux.symfony.com] Fix rendering/color issues on Map page #2069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ux.symfony.com/assets/styles/components/_PackageHeader.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
.PackageHeader {
h1 {
text-shadow: 0 .25rem .25rem rgba(0, 0, 0, .05);
text-wrap: balance;

em {
display: inline-flex;
Expand Down
3 changes: 1 addition & 2 deletions ux.symfony.com/src/Service/UxPackageRepository.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@ public function findAll(?string $query = null): array
'map',
'UX Map',
'app_map',
'#fff',
// 'linear-gradient(to bottom right, #58D984EB, #0083A2D1), #3386dfd4',
'#1BA980',
'linear-gradient(to bottom right, #1BA980, #209127 75%, #C0CB2A)',
'Interactive Maps',
'Render interactive Maps in PHP with Leaflet or Google Maps.',
Expand Down
21 changes: 12 additions & 9 deletions ux.symfony.com/templates/ux_packages/map.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,18 @@
{% set package = 'map'|ux_package %}

{% block package_header %}
<twig:Hero
eyebrows="Assert('Mapper')"
title="UX Map"
url="{{ url('app_map') }}"
>
Embed <code>interactive maps</code> in your Symfony application in a breeze!
<br />
Decouple your code from your map provider: <code>Google Maps</code>, <code>LeaftLet</code>.
</twig:Hero>
{% component PackageHeader with {
package: 'map',
eyebrowText: 'Seamless Maps Integration',
} %}
{% block title_header %}
Embed <em>interactive maps</em> in a breeze!
{% endblock %}

{% block sub_content %}
Decouple your code from your map provider: <em>Google Maps</em>, <em>LeaftLet</em>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand this syntax what do you think about something like: Seamlessly connect with any map provider, like Google Maps or Leaflet.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seamless is used in the eyebrow, and decouple felt a good thing to expose as it is an important promise of the component, but i agree this sentence could be more catchy / efficient

{% endblock %}
{% endcomponent %}
Comment on lines +6 to +17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use the HTML syntax?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not used elsewhere for now. I used it in the first version of this page with the new component but here it feels more coherent.

But all this will really soon change so i don't mind :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just go for the fastest (all other packages use this syntax), hoping this PR could quickly be merged and deployed :)

{% endblock %}

{% block code_block_left %}
Expand Down