[ux.symfony.com] Fix rendering/color issues on Map page #2069
Conversation
carsonbot
added
Bug
Kocal
force-pushed
the
fix/ux-symfony-com-adujustements
branch
from
6d93d1d to
bd7a430
Compare
carsonbot
added
Status: Reviewed
| {% component PackageHeader with { | ||
| package: 'map', | ||
| eyebrowText: 'Seamless Maps Integration', | ||
| } %} | ||
| {% block title_header %} | ||
| Embed <em>interactive maps</em> in a breeze! | ||
| {% endblock %} | ||
|
|
||
| {% block sub_content %} | ||
| Decouple your code from your map provider: <em>Google Maps</em>, <em>LeaftLet</em>. | ||
| {% endblock %} | ||
| {% endcomponent %} |
There was a problem hiding this comment.
Why not use the HTML syntax?
There was a problem hiding this comment.
It's not used elsewhere for now. I used it in the first version of this page with the new component but here it feels more coherent.
But all this will really soon change so i don't mind :)
There was a problem hiding this comment.
I've just go for the fastest (all other packages use this syntax), hoping this PR could quickly be merged and deployed :)
| {% endblock %} | ||
|
|
||
| {% block sub_content %} | ||
| Decouple your code from your map provider: <em>Google Maps</em>, <em>LeaftLet</em>. |
There was a problem hiding this comment.
I don't really understand this syntax what do you think about something like: Seamlessly connect with any map provider, like Google Maps or Leaflet.
There was a problem hiding this comment.
Seamless is used in the eyebrow, and decouple felt a good thing to expose as it is an important promise of the component, but i agree this sentence could be more catchy / efficient
kbond
force-pushed
the
fix/ux-symfony-com-adujustements
branch
from
bd7a430 to
c3a8806
Compare
|
Thanks Hugo. |
It looks like we have some visual issues in light mode on the Map page, we can't see the menu:
And we miss the
composer require ...thing.I've Replaced the usage of the new component
Hero(introduced in #2053) by the good oldPackageHeadercomponent.This is the quickest solution right now to correctly render UX Map page, and it gives us some times to improve this
Herocomponent and re-use it in all UX package pages.EDIT: I've seen with @smnandre for some minor adjustements:
