[TwigComponents] Fixing inconsistency with how {% component rendered vs {{ component() #1247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just tried, both "TwigComponent should pass" tests are OK |
|
DebugCommand seems OK after a couple of tests |
…vs {{ component()
weaverryan
force-pushed
the
twig-components-improved-embed
branch
from
06f6b07 to
df6388e
Compare
|
@smnandre would you mind rebasing your 2 PR's? I'd like to verify they pass - then we can merge those in |
Will do in 2/3 hours |
smnandre
added a commit
to smnandre/ux
that referenced
this pull request
Apr 23, 2024
I believe this modification fix issue symfony#1754 **Original problem** If you render a template @Acme/dashboard.html.twig, embedded Components (live or twig) referenced wrong template (dashboard.html.twig here), making LiveComponent impossible to rerender (this file beeing not referenced in the TemplateMap). This behaviour was introduced in symfony#1082 (and worked then). But i'm convinced all the work/changes made by Ryan to fix the embed bug (symfony#1247 and related) made this obselete (and in this particular situation even originates a bug) All tests are green, and i'd like to test it more heavily... but before that : do you think this is a bug fix or is there some kind of BC break here?
smnandre
added a commit
to smnandre/ux
that referenced
this pull request
Apr 24, 2024
I believe this modification fix issue symfony#1754 **Original problem** If you render a template @Acme/dashboard.html.twig, embedded Components (live or twig) referenced wrong template (dashboard.html.twig here), making LiveComponent impossible to rerender (this file beeing not referenced in the TemplateMap). This behaviour was introduced in symfony#1082 (and worked then). But i'm convinced all the work/changes made by Ryan to fix the embed bug (symfony#1247 and related) made this obselete (and in this particular situation even originates a bug) All tests are green, and i'd like to test it more heavily... but before that : do you think this is a bug fix or is there some kind of BC break here?
kbond
added a commit
that referenced
this pull request
Apr 25, 2024
This PR was squashed before being merged into the 2.x branch. Discussion ---------- [TwigComponent] Fix LiveComponent namespace mapping I believe this modification fix #1754 **Original problem** If you render a template `@Acme`/dashboard.html.twig, embedded Components (live or twig) referenced wrong template (dashboard.html.twig here), making LiveComponent impossible to rerender (this file beeing not referenced in the TemplateMap). This behaviour was introduced in #1082 (and worked then). But i'm convinced all the work/changes made by Ryan to fix the embed bug (#1247 and related) made this obselete (and in this particular situation even originates a bug) All tests are green, and i'd like to test it more heavily... but before that : do you think this is a bug fix or is there some kind of BC break here? Commits ------- bb76055 [TwigComponent] Fix LiveComponent namespace mapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr
{% componentwas rendered slightly differently than{{ component. Additionally, for{% component, the template was determined too early, which didn't allow for the template to be overridden via an event.Longer Explanation
This cleans up
ComponentTokenParser, removing some unnecessary parts. We now always set the "embedded" component parent to a magic__parent__variable. This allows us to delay the determination of the component template until runtime, after thePreRenderEventhas been called.TODO:
Cheers!