[TwigComponent] Add tests ComponentRenderer should pass #1237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
reviewed
Oct 28, 2023
| * | ||
| * @see PreRenderEvent | ||
| */ | ||
| class FooBarComponentTemplateListener |
There was a problem hiding this comment.
Is this registered in the test kernel and being used?
There was a problem hiding this comment.
It is registered (the test kernel has autowire+autoconfigure for the entire namespace) and it is used
There are 4 data provided / tested in src/TwigComponent/tests/Integration/ComponentEventTest.php and only two fail because the FooBarComponentTemplateListener is called
3 tasks
weaverryan
added a commit
that referenced
this pull request
Nov 6, 2023
…nent rendered vs {{ component() (weaverryan)
This PR was squashed before being merged into the 2.x branch.
Discussion
----------
[TwigComponents] Fixing inconsistency with how {% component rendered vs {{ component()
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| Issues | Fix #1205 (?) and maybe others?
| License | MIT
tl;dr `{% component` was rendered slightly differently than `{{ component`. Additionally, for `{% component`, the template was determined too early, which didn't allow for the template to be overridden via an event.
**Longer Explanation**
This cleans up `ComponentTokenParser`, removing some unnecessary parts. We now always set the "embedded" component parent to a magic `__parent__` variable. This allows us to delay the determination of the component template until runtime, after the `PreRenderEvent` has been called.
TODO:
* [ ] Bring in tests from #1236 and #1237 and check other tests
* [ ] Check #1205 to verify this fixes
* [ ] Check debug:twig-component command for any changes needed
Cheers!
Commits
-------
df6388e [TwigComponents] Fixing inconsistency with how {% component rendered vs {{ component()
smnandre
force-pushed
the
dx/add-event-listener-tests
branch
from
e43356c to
0b154f3
Compare
|
Ready here @weaverryan ... and the tests are green thanks to you :) |
weaverryan
force-pushed
the
dx/add-event-listener-tests
branch
from
0b154f3 to
3ffae76
Compare
|
Thanks Simon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As written in the documentation, it is possible to modify the template during the PreRenderEvent, so those tests should pass.