Move src/Migrations/ to migrations/ #797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
deployed
to
fabpot
approved these changes
Jul 14, 2020
weaverryan
approved these changes
Jul 14, 2020
Closed
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jul 15, 2020
This PR was merged into the 5.0 branch. Discussion ---------- default path of migrations changed in recipe See symfony/recipes#797 Obviously, we can't really know what path the user will have configured. All we can do is have it match the latest config. Btw, I chose 5.0 as the base branch... but I'm open to other suggestions. Cheers! Commits ------- 3be2860 default path of migrations changed in recipe
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Sep 7, 2020
This PR was submitted for the 5.1 branch but it was merged into the 4.4 branch instead. Discussion ---------- Update best_practices.rst Related to symfony/recipes#797 Commits ------- 3371108 Update best_practices.rst
|
This creates a new empty directory, leaving existing migrations in the old directory instead of moving them. Is that intentional? (Do recipes have the power to move files outside the recipe?) |
|
You're correct, recipes don't move files. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there anything that prevents doing so, if the book can be fixed?
Replaces #796