Skip to content

Put migrations back in src/Migrations/ #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Put migrations back in src/Migrations/ #796

wants to merge 1 commit into from

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Jul 14, 2020

Q A
License MIT
Doc issue/PR -

Changing this directory made the recipes incompatible with the-fast-track book.
Since the book is an important asset for the community, we'd better not break it.

Changes #729
Invalidates #718

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@nicolas-grekas
Copy link
Member Author

nicolas-grekas commented Jul 14, 2020

Note that I don't know what the exact impact of "fixing" the book would be. Printed ones are not fixable for sure, but maybe that's not critical enough and this PR can be rejected?
Only @fabpot knows :)

@fabpot
Copy link
Member

fabpot commented Jul 14, 2020

Using '/migrations' for all versions of Doctrine seems like a great idea (which we've already talked about in the past).

@nicolas-grekas nicolas-grekas deleted the migrations branch July 14, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants