Skip to content

Add Docker support for the Mercure recipe #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Aug 8, 2019
Merged

Add Docker support for the Mercure recipe #583

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions symfony/mercure-bundle/0.1/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,25 @@
"env(MERCURE_JWT_SECRET)": ""
},
"env": {
"MERCURE_PUBLISH_URL": "https://demo.mercure.rocks/hub",
"MERCURE_JWT_SECRET": "#see https://mercure.rocks"
"#1": "See https://symfony.com/doc/current/mercure.html#configuration",
"MERCURE_PUBLISH_URL": "http://mercure/hub",
"MERCURE_JWT_SECRET": "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJtZXJjdXJlIjp7InB1Ymxpc2giOltdfX0.Oo0yg7y4yMa1vr_bziltxuTCqb8JVHKxp-f_FwwOim0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why this was never mentioned, but apparently the secret used here is:

!ChangeMe!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's mentioned here: https://github.com/symfony/recipes/pull/583/files#diff-d19ccce8daab2b00dbfa4e827ebde212R24
But indeed it must be added as a comment in .env. Can you open a PR please?

},
"docker-compose": {
"services": [
"mercure:",
" # In production, you may want to use the managed version of Mercure, https://mercure.rocks",
" image: dunglas/mercure",
" environment:",
" # You should definitely change all these values in production",
" - JWT_KEY=!ChangeMe!",
" - ALLOW_ANONYMOUS=1",
" - CORS_ALLOWED_ORIGINS=*",
" - PUBLISH_ALLOWED_ORIGINS=http://localhost:1337",
" - DEMO=1",
" ports:",
" - \"1337:80\""
]
},
"aliases": ["mercure"]
}