Add Docker support for the Mercure recipe #583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
suggested changes
Apr 28, 2019
ghost
suggested changes
Apr 28, 2019
ghost
deployed
to
maxhelias
approved these changes
May 13, 2019
fabpot
requested changes
May 14, 2019
fabpot
approved these changes
Aug 2, 2019
teohhanhui
reviewed
Aug 23, 2019
| "MERCURE_JWT_SECRET": "#see https://mercure.rocks" | ||
| "#1": "See https://symfony.com/doc/current/mercure.html#configuration", | ||
| "MERCURE_PUBLISH_URL": "http://mercure/hub", | ||
| "MERCURE_JWT_SECRET": "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJtZXJjdXJlIjp7InB1Ymxpc2giOltdfX0.Oo0yg7y4yMa1vr_bziltxuTCqb8JVHKxp-f_FwwOim0" |
There was a problem hiding this comment.
I don't know why this was never mentioned, but apparently the secret used here is:
!ChangeMe!
There was a problem hiding this comment.
It's mentioned here: https://github.com/symfony/recipes/pull/583/files#diff-d19ccce8daab2b00dbfa4e827ebde212R24
But indeed it must be added as a comment in .env. Can you open a PR please?
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs symfony/flex#128