Skip to content

[YSM] fix array key regex #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2021
Merged

Conversation

jrushlow
Copy link
Collaborator

This fixes an issue if an existing array has a : within the value, YamlSourceManipulator could mistake part of the value for the array key when determining position.

E.g.

config:
    - '80:80'

YSM would pick the 0: within 80:80 as the array key.

@jrushlow jrushlow added the Status: Needs Review Needs to be reviewed label Feb 16, 2021
@jrushlow
Copy link
Collaborator Author

jrushlow commented Feb 16, 2021

This should fix #777. But does not handle passing a literal "80:80" as a new array value and getting '80:80' in return. PR #782 is a WIP for this "issue" with an unknown future.

@jrushlow jrushlow added Related Tests Pass Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Feb 16, 2021
@weaverryan
Copy link
Member

Thanks for hunting this down Jesse!

@weaverryan weaverryan merged commit f461d07 into symfony:main Feb 17, 2021
@jrushlow jrushlow deleted the fix/docker-port-regex branch March 3, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Related Tests Pass Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants