add failing test for issue 777

[jrushlow]

WIP
fixes #777

[weaverryan]

For purposes of figuring out the root cause, if you changed this from "80:80" to "foo_bar", does the error happen?

Or, if you use '80:80' with single quotes - error or no?

[weaverryan]

Again for purposes of figuring out the root cause, if you changed this from "443:443" to "foo_bar", does the error happen?

[jrushlow]

This test passes. but not w/ "80:80"

[weaverryan]

So we don't change the existing double quotes to single quotes. It's only that the NEW keys we add are double quotes? If so, I think it's fine.

[jrushlow]

Partial YSM: Debug for case array_double_quoted_80_value_single.test with "80:80" in place of "foo:foo"

...
START key
            key: ports
          depth: 1
       position: 6
    indentation: 0
           type: hash
         format: multi
        content: >\r\n    ports:\r\n      - "80:80"\r\n    volumes:\r\n     <

Advancing position beyond key "ports"
            key: ports
          depth: 1
       position: 6
    indentation: 0
           type: hash
         format: multi

advanceCurrentPosition() from 6 to 18
            key: ports
          depth: 1
       position: 6
    indentation: 0
           type: hash
         format: multi
        content: >\r\n    ports:\r\n      - "80:80"\r\n    volumes:\r\n     <

Calculating new indentation: changing from 0 to 4
            key: ports
          depth: 1
       position: 18
    indentation: 0
           type: hash
         format: multi
        content: >\r\n      - "80:80"\r\n    volumes:\r\n      - caddy_dat<

Calling updateData() on next level
            key: ports
          depth: 1
       position: 18
    indentation: 4
           type: hash
         format: multi

Changing array type & format via updateData() (type=sequence, format=multi)
            key: n/a
          depth: 2
       position: 19
    indentation: 4
           type: sequence
         format: multi

Advancing position beyond PREV key
            key: 0
          depth: 2
       position: 19
    indentation: 4
           type: sequence
         format: multi

advanceCurrentPosition() from 19 to 30
            key: 0
          depth: 2
       position: 19
    indentation: 4
           type: sequence
         format: multi
        content: >\n      - "80:80"\r\n    volumes:\r\n      - caddy_data<

Calculating new indentation: changing from 4 to 6
            key: 0
          depth: 2
       position: 30
    indentation: 4
           type: sequence
         format: multi
        content: >0:80"\r\n    volumes:\r\n      - caddy_data<

START key
            key: 0
          depth: 2
       position: 30
    indentation: 6
           type: sequence
         format: multi
        content: >0:80"\r\n    volumes:\r\n      - caddy_data<

Advancing position beyond key "0"
            key: 0
          depth: 2
       position: 30
    indentation: 6
           type: sequence
         format: multi

advanceCurrentPosition() from 30 to 32
            key: 0
          depth: 2
       position: 30
    indentation: 6
           type: sequence
         format: multi
        content: >0:80"\r\n    volumes:\r\n      - caddy_data<

Calculating new indentation: changing from 6 to 6
            key: 0
          depth: 2
       position: 32
    indentation: 6
           type: sequence
         format: multi
        content: >80"\r\n    volumes:\r\n      - caddy_data<

value did not change
            key: 0
          depth: 2
       position: 32
    indentation: 6
           type: sequence
         format: multi

Advancing position beyond value "80:80"
            key: 0
          depth: 2
       position: 32
    indentation: 6
           type: sequence
         format: multi

[jrushlow]

Part of the problem is in

maker-bundle/src/Util/YamlSourceManipulator.php

Line 592 in 313b566

preg_match($this->getKeyRegex($key), $this->contents, $matches, \PREG_OFFSET_CAPTURE, $this->currentPosition);

$key = 0;

$regex = $this->getKeyRegex($key);

var_dump($regex);  // `0( )*:`

which hits on the first 0 of the value "80:80"

[jrushlow]

The second part of the problem - When you set a value - "bar:baz"

Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
 'caddy:
     ports:
       - "80:80"
-      - "bar:baz"
+      - 'bar:baz'
     volumes:
       - caddy_data'

which is caused by Update: YSM does not preserve quotes on array values. So - 'foo' or - "foo" are both passed as foo within YSM - not 'foo' or "foo"

maker-bundle/src/Util/YamlSourceManipulator.php

Line 720 in 313b566

$newDataString = Yaml::dump($data, 4, $indent);

`

[jrushlow]

fix for this was provided in #816 & #818