[make:*] Use a PHP-CS-Fixer shim rather than an external PHAR #1575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @theofidry - I didn't realize phpcsfixer had created a shim since we introduced this feature. I'm definitely all for it as it will save me from having to maintain the I'll need to do some toying around with this locally before we merge to make sure we are on the up and up. |
jrushlow
force-pushed
the
build/php-cs-fixer-shim
branch
from
de5f4d8
to
86c658d
Compare
jrushlow
changed the title
jrushlow
added
Status: Reviewed
jrushlow
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Thank you @theofidry! This will give the user the ability to use an up to date version of PHP-CS-Fixer without having to wait around on maintainers to update the phar manually. Win Win...
jrushlow
force-pushed
the
build/php-cs-fixer-shim
branch
from
087ef42
to
2dd07dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to leverage the PHP-CS-Fixer shim package, which is the Composer package shipping the scoped PHAR, rather than managing the PHAR directly.
IMO it is better because on the maintainer side it is a package like usual and you do not have the downside of polluting your project.
There is however the downside still that a project could use a shim with an incompatible version... And this may not be desired. In which case simply ignore this PR! :)