php-cs-fixer/shim is userland

[Chris53897]

is it intended that php-cs-fixer/shim is in require and not in require-dev?
4735ff1#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34R19

Now friendsofphp/php-cs-fixer will be uninstalled and php-cs-fixer/shim will be installed in userland code.

@theofidry @jrushlow

[theofidry]

Now friendsofphp/php-cs-fixer will be uninstalled and php-cs-fixer/shim will be installed in userland code.

You'll need to expend on why this is the case, it is not the expected behaviour for sure.

From this (symfony/maker-bundle) perspective, the shim is a required dependency: it relies on it to execute it against generated code (so it uses it as part of its source code). However, you likely consume this library as a dev dependency so the shim would remain a dev dependency from your application.

[Chris53897]

I hope this infos will help.
Yes it is still a dev-dependency.
But there are some little DX issues. PHP-CS-Fixer/PHP-CS-Fixer#8372 (comment)

my composer.json

"friendsofphp/php-cs-fixer": "^3.68",
"symfony/maker-bundle": "^1.62",

symfony composer update

`Symfony operations: 4 recipes (e3eb63c1ad767ffc8e3fff791285e9d0)

• Configuring php-cs-fixer/shim (>=3.0): From github.com/symfony/recipes:main
• Unconfiguring friendsofphp/php-cs-fixer (>=3.0): From github.com/symfony/recipes:main
• Unconfiguring composer/xdebug-handler (>=3.0.5): From auto-generated recipe
• Unconfiguring composer/pcre (>=3.3.2): From auto-generated recipe
  `

[Seb33300]

Adding php-cs-fixer/shim as a required dependency trigger the php-cs-fixer/shim recipe in our project:
https://github.com/symfony/recipes/tree/main/php-cs-fixer/shim

[kbond]

I've reverted #1575 and released v1.62.1. It was causing a lot of problems. I think we need to rethink the php-cs-fixer integration.