[make:entity] Property types, Types:: constant & type guessing

[weaverryan]

Hi!

This expands on the excellent work in #1039. This adds to make:entity:

A) Property types - e.g. private ?int $id = null. Most property types are nullable and default to null, effectively making them typed, but identical to how things worked before (before types, properties were naturally nullable and defaulted to null).

B) Removes most type: options in ORM\Column as these are now "guessed" since doctrine/orm 2.9 from the property types.

C) For the few type: options that remain, we use a Types:: constant.

Cheers!

[weaverryan]

This is ready! The Symfony 6.2.x-dev failures are from an upstream bug - symfony/symfony#46916

[jrushlow]

Shweet! Couple of minor comments...

[jrushlow]

Is this for code readability?

[jrushlow]

Awesome Work! Thanks @Geekimo && @weaverryan

[Geekimo]

Thanks @weaverryan for updating my work !

[icedevelopment]

@Geekimo @weaverryan first off, nice work! I noticed this PR explicitely adds = null after each property which doesn't seem necessary as they should already default to null or maybe I'm missing something?

[Geekimo]

@icedevelopment Hello, thanks.
A property never defaults to null unless it is explicitely specified.
If you do not set a default value, it won't be accessible unless initialized via an affectation.

[jorismak]

phpstan now always flags the properties as incorrect, because the database says 'not null' and the PHP code says 'nullable'.

I know that you can't access an uninitialized property, but forcing it to null... is that right?

We've worked for years with non-nullable properties this way. You set them in the constructor if you want safe, or other coding standards..

I'm now in doubt if I need to ignore the errors in phpstan, or adjust the scaffolding from make:entity to make the nullable types match the database layout.

Maybe from my C/C++ background, but an uninitialized property (and the dangers of it :P) sound perfectly fine in my head :).