Skip to content

make:entity Add use of Doctrine types constants in attributes #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

make:entity Add use of Doctrine types constants in attributes #1039

wants to merge 7 commits into from

Conversation

Geekimo
Copy link
Contributor

@Geekimo Geekimo commented Dec 18, 2021

Makes use of Doctrine\DBAL\Types\Types in entities using PHP8 attributes instead of string values for column type.

@Geekimo Geekimo force-pushed the feat/attributes-columns-types-as-constants branch from 43c5dcb to bb1566e Compare December 18, 2021 13:07
@Geekimo
Copy link
Contributor Author

Geekimo commented Dec 28, 2021

Hello,
Looks like it's ok from my side. All failing tests doesn't look to be linked to my modifications. If anyone can give me a hint if this is the case.

jrushlow
jrushlow requested changes Feb 15, 2022
View reviewed changes
Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Geekimo for the work on this. Could you squash & rebase this please? Also github is flagging your commits as Unverified due to lack of a commit signature. (Github vigilante mode)

@jrushlow jrushlow added the Status: Needs Work Additional work is needed label Feb 22, 2022
@jrushlow jrushlow added the Feature New Feature label Mar 3, 2022
@jrushlow jrushlow changed the title feat(entity): Add use of Doctrine types constants in attributes make:entity Add use of Doctrine types constants in attributes Jul 5, 2022
@jrushlow jrushlow force-pushed the feat/attributes-columns-types-as-constants branch from 4b24db8 to 90ab4b5 Compare July 5, 2022 13:14
@weaverryan weaverryan force-pushed the feat/attributes-columns-types-as-constants branch from 477d5b5 to 353aea6 Compare July 11, 2022 18:41
@weaverryan weaverryan mentioned this pull request Jul 11, 2022
Merged
@weaverryan
Copy link
Member

I've continued the work (with the original commits) over on #1147. Thanks @Geekimo for kicking this off!

@weaverryan weaverryan closed this Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrushlow jrushlow jrushlow requested changes

Assignees
No one assigned
Labels
Feature New Feature Status: Needs Work Additional work is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Geekimo @weaverryan @jrushlow