Skip to content

Conversation

@chr-hertel
Copy link
Member

@chr-hertel chr-hertel commented Jun 6, 2025

Q A
Bug fix? no
New feature? yes
Docs? yes
Issues
License MIT

Replaces #14 since this is coming with the git history.

  • Splits LLM Chain into three components as packages
  • Renames Chain component to Agent
  • Renames PhpLlm\LlmChain into Symfony\AI

chr-hertel and others added 30 commits September 22, 2024 22:59
Or what about naming it `merge()`?
* Helpful exceptions
* Introduce `Model` value object
* More specific exception
…implementations (#25)

* Allow usage of gpt visions api

* Add tests

* Rename content classes

* Move content casting of user message to message object

* Simplify message interface with content classes

* Rename variable

* Fix image describer after latest interface change

* Some review adjustments
* Change sentence in `README`

* -
* Fix wrong namespace

* -
* Read description for schema to gove more context to the LLM

* -
No need to run cs-fixer, PHPStan etc. so often with different PHP versions
* [Store][Azure] Make vector field name configurable

* -
* Add links for stores

* -

* -
* Better options handling

* Update examples/chat-gpt-openai.php

* Apply suggestions from code review
As we don't have support for it now
* Remove method `Vector::create1536`

* -
@chr-hertel chr-hertel force-pushed the chain-integration branch from c61bd5f to 1e1f12d Compare June 6, 2025 23:24
@chr-hertel chr-hertel marked this pull request as ready for review June 6, 2025 23:25
@chr-hertel chr-hertel requested a review from Nyholm as a code owner June 6, 2025 23:25
@chr-hertel chr-hertel force-pushed the chain-integration branch 3 times, most recently from 574f8f2 to 94ba24d Compare June 7, 2025 00:09
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pr is too big and the project is too young. Let's merge so we can collaborate and improve from main

@chr-hertel
Copy link
Member Author

Yes agree, in this case it makes sense not to squash and have a merge commit to preserve the history.

Would you still use gh or just hit the button?

@fabpot
Copy link
Member

fabpot commented Jun 7, 2025

Just rebase first to get rid of the merge commits and gh will work fine.

@chr-hertel
Copy link
Member Author

the reason for the merge commit here is that I integrated llm-chain with merge --unrelated-history on top of what we have here.

another option i see is to use the llm-chain history as base and rebase the history of symfony/ai on top of that - at least that would be easier than rebasing those 300 commits that conflict in structure 🙈

@chr-hertel
Copy link
Member Author

@Nyholm any objections from your end if i wipe main for now and rebase the current status on top of this here?
at least i'd give it a try - should be easier than the other way around
not sure i'm able to do a force push on main tho :D

@fabpot
Copy link
Member

fabpot commented Jun 7, 2025

If it’s too complicated, don’t bother and just hit the merge button.

@chr-hertel chr-hertel force-pushed the chain-integration branch from 94ba24d to 7b7dc8c Compare June 7, 2025 13:32
@chr-hertel chr-hertel merged commit 7b7dc8c into main Jun 7, 2025
25 checks passed
chr-hertel added a commit that referenced this pull request Jun 7, 2025
* Rename `Registry` to `Toolbox`

* refactor: rename tool registry to ToolBox

---------

Co-authored-by: Christopher Hertel <mail@christopher-hertel.de>
@chr-hertel chr-hertel deleted the chain-integration branch June 7, 2025 13:37
@chr-hertel
Copy link
Member Author

reworded the big library merge, squashed the Symfony AI changes on top and merged with no commit on main. the best way out for the history without too much of a stress.

done here :)

chr-hertel added a commit that referenced this pull request Jun 22, 2025
* demo-repo/restructure: (31 commits)
  refactor: restructure into demo folder
  chore: update to llm-chain 0.22 (#27)
  refactor: more error handling in vidoe example
  chore: symfony 7.3 update
  fix: pin chroma db version and clean up (#26)
  feat: add demo of GPT vision capabilities based on video stream (#22)
  chore: dependecy update (#23)
  feat: extend wikipedia system prompt by tools (#21)
  chore: update to lib v0.19 (#20)
  refactor: optimize audio chat ui (#19)
  feat: audio example (#18)
  chore: updating dependencies (#17)
  chore: composer update incl twig cve patch (#16)
  chore: llm chain update with system_prompt support (#15)
  chore: install bundle 0.12 (#14)
  chore: update to llm-chain 0.11.0 (#13)
  chore: library update (#12)
  refactor: follow up on example structure to have them cleaner and more separated (#11)
  fix: typed animation only on xhr responses (#10)
  refactor: moving classes to a more component like structure (#9)
  ...
chr-hertel added a commit that referenced this pull request Jun 22, 2025
* demo-repo/restructure: (31 commits)
  refactor: restructure into demo folder
  chore: update to llm-chain 0.22 (#27)
  refactor: more error handling in vidoe example
  chore: symfony 7.3 update
  fix: pin chroma db version and clean up (#26)
  feat: add demo of GPT vision capabilities based on video stream (#22)
  chore: dependecy update (#23)
  feat: extend wikipedia system prompt by tools (#21)
  chore: update to lib v0.19 (#20)
  refactor: optimize audio chat ui (#19)
  feat: audio example (#18)
  chore: updating dependencies (#17)
  chore: composer update incl twig cve patch (#16)
  chore: llm chain update with system_prompt support (#15)
  chore: install bundle 0.12 (#14)
  chore: update to llm-chain 0.11.0 (#13)
  chore: library update (#12)
  refactor: follow up on example structure to have them cleaner and more separated (#11)
  fix: typed animation only on xhr responses (#10)
  refactor: moving classes to a more component like structure (#9)
  ...
chr-hertel added a commit that referenced this pull request Jun 23, 2025
* demo-repo/restructure: (31 commits)
  refactor: restructure into demo folder
  chore: update to llm-chain 0.22 (#27)
  refactor: more error handling in vidoe example
  chore: symfony 7.3 update
  fix: pin chroma db version and clean up (#26)
  feat: add demo of GPT vision capabilities based on video stream (#22)
  chore: dependecy update (#23)
  feat: extend wikipedia system prompt by tools (#21)
  chore: update to lib v0.19 (#20)
  refactor: optimize audio chat ui (#19)
  feat: audio example (#18)
  chore: updating dependencies (#17)
  chore: composer update incl twig cve patch (#16)
  chore: llm chain update with system_prompt support (#15)
  chore: install bundle 0.12 (#14)
  chore: update to llm-chain 0.11.0 (#13)
  chore: library update (#12)
  refactor: follow up on example structure to have them cleaner and more separated (#11)
  fix: typed animation only on xhr responses (#10)
  refactor: moving classes to a more component like structure (#9)
  ...
chr-hertel added a commit that referenced this pull request Jun 23, 2025
* integrate-demo: (31 commits)
  refactor: restructure into demo folder
  chore: update to llm-chain 0.22 (#27)
  refactor: more error handling in vidoe example
  chore: symfony 7.3 update
  fix: pin chroma db version and clean up (#26)
  feat: add demo of GPT vision capabilities based on video stream (#22)
  chore: dependecy update (#23)
  feat: extend wikipedia system prompt by tools (#21)
  chore: update to lib v0.19 (#20)
  refactor: optimize audio chat ui (#19)
  feat: audio example (#18)
  chore: updating dependencies (#17)
  chore: composer update incl twig cve patch (#16)
  chore: llm chain update with system_prompt support (#15)
  chore: install bundle 0.12 (#14)
  chore: update to llm-chain 0.11.0 (#13)
  chore: library update (#12)
  refactor: follow up on example structure to have them cleaner and more separated (#11)
  fix: typed animation only on xhr responses (#10)
  refactor: moving classes to a more component like structure (#9)
  ...
@chr-hertel chr-hertel added Platform Issues & PRs about the AI Platform component Agent Issues & PRs about the AI Agent component Store Issues & PRs about the AI Store component Run examples Issues & PRs about the example scripts labels Jul 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Agent Issues & PRs about the AI Agent component Platform Issues & PRs about the AI Platform component Run examples Issues & PRs about the example scripts Store Issues & PRs about the AI Store component

Projects

None yet

Development

Successfully merging this pull request may close these issues.