Skip to content

Conversation

@Nyholm
Copy link
Member

@Nyholm Nyholm commented May 29, 2025

Q A
Bug fix? no
New feature? no
Docs? no
Issues
License MIT

There is one new feature here: A notification can be handled by multiple notification handlers.

@Nyholm Nyholm requested a review from chr-hertel as a code owner May 29, 2025 21:27
@chr-hertel
Copy link
Member

usually I'd vote for not having the @throws tag - only on an interface with explicit description of what it should express.

but that's rather opinionated and style - i just disable that phpstorm inspection because i don't see the value while reading the code and in CI we don't check for it

Copy link
Member

@chr-hertel chr-hertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that! :)

we should aling on those style things tho

@Nyholm Nyholm merged commit 9b534aa into main May 30, 2025
12 checks passed
@chr-hertel chr-hertel deleted the tests branch May 30, 2025 10:27
chr-hertel pushed a commit that referenced this pull request Jun 6, 2025
* Introduce `Model` value object
chr-hertel pushed a commit that referenced this pull request Jun 13, 2025
chr-hertel added a commit that referenced this pull request Jun 22, 2025
chr-hertel added a commit that referenced this pull request Jun 22, 2025
* demo-repo/restructure: (31 commits)
  refactor: restructure into demo folder
  chore: update to llm-chain 0.22 (#27)
  refactor: more error handling in vidoe example
  chore: symfony 7.3 update
  fix: pin chroma db version and clean up (#26)
  feat: add demo of GPT vision capabilities based on video stream (#22)
  chore: dependecy update (#23)
  feat: extend wikipedia system prompt by tools (#21)
  chore: update to lib v0.19 (#20)
  refactor: optimize audio chat ui (#19)
  feat: audio example (#18)
  chore: updating dependencies (#17)
  chore: composer update incl twig cve patch (#16)
  chore: llm chain update with system_prompt support (#15)
  chore: install bundle 0.12 (#14)
  chore: update to llm-chain 0.11.0 (#13)
  chore: library update (#12)
  refactor: follow up on example structure to have them cleaner and more separated (#11)
  fix: typed animation only on xhr responses (#10)
  refactor: moving classes to a more component like structure (#9)
  ...
chr-hertel added a commit that referenced this pull request Jun 22, 2025
* demo-repo/restructure: (31 commits)
  refactor: restructure into demo folder
  chore: update to llm-chain 0.22 (#27)
  refactor: more error handling in vidoe example
  chore: symfony 7.3 update
  fix: pin chroma db version and clean up (#26)
  feat: add demo of GPT vision capabilities based on video stream (#22)
  chore: dependecy update (#23)
  feat: extend wikipedia system prompt by tools (#21)
  chore: update to lib v0.19 (#20)
  refactor: optimize audio chat ui (#19)
  feat: audio example (#18)
  chore: updating dependencies (#17)
  chore: composer update incl twig cve patch (#16)
  chore: llm chain update with system_prompt support (#15)
  chore: install bundle 0.12 (#14)
  chore: update to llm-chain 0.11.0 (#13)
  chore: library update (#12)
  refactor: follow up on example structure to have them cleaner and more separated (#11)
  fix: typed animation only on xhr responses (#10)
  refactor: moving classes to a more component like structure (#9)
  ...
chr-hertel added a commit that referenced this pull request Jun 23, 2025
* demo-repo/restructure: (31 commits)
  refactor: restructure into demo folder
  chore: update to llm-chain 0.22 (#27)
  refactor: more error handling in vidoe example
  chore: symfony 7.3 update
  fix: pin chroma db version and clean up (#26)
  feat: add demo of GPT vision capabilities based on video stream (#22)
  chore: dependecy update (#23)
  feat: extend wikipedia system prompt by tools (#21)
  chore: update to lib v0.19 (#20)
  refactor: optimize audio chat ui (#19)
  feat: audio example (#18)
  chore: updating dependencies (#17)
  chore: composer update incl twig cve patch (#16)
  chore: llm chain update with system_prompt support (#15)
  chore: install bundle 0.12 (#14)
  chore: update to llm-chain 0.11.0 (#13)
  chore: library update (#12)
  refactor: follow up on example structure to have them cleaner and more separated (#11)
  fix: typed animation only on xhr responses (#10)
  refactor: moving classes to a more component like structure (#9)
  ...
chr-hertel added a commit that referenced this pull request Jun 23, 2025
* integrate-demo: (31 commits)
  refactor: restructure into demo folder
  chore: update to llm-chain 0.22 (#27)
  refactor: more error handling in vidoe example
  chore: symfony 7.3 update
  fix: pin chroma db version and clean up (#26)
  feat: add demo of GPT vision capabilities based on video stream (#22)
  chore: dependecy update (#23)
  feat: extend wikipedia system prompt by tools (#21)
  chore: update to lib v0.19 (#20)
  refactor: optimize audio chat ui (#19)
  feat: audio example (#18)
  chore: updating dependencies (#17)
  chore: composer update incl twig cve patch (#16)
  chore: llm chain update with system_prompt support (#15)
  chore: install bundle 0.12 (#14)
  chore: update to llm-chain 0.11.0 (#13)
  chore: library update (#12)
  refactor: follow up on example structure to have them cleaner and more separated (#11)
  fix: typed animation only on xhr responses (#10)
  refactor: moving classes to a more component like structure (#9)
  ...
@chr-hertel chr-hertel added the MCP SDK Issues & PRs about the MCP SDK label Jul 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

MCP SDK Issues & PRs about the MCP SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants