PHP 7.2 compatibility: check if sortedRouters is null before trying to count it #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you for checking this and providing a fix! lets initialize in the property declaration with an empty array, its also what the add() method does to reset the sortedRouter field. can you please adjust the pull request accordingly? |
…l) yields warning
maff
force-pushed
the
php7.2-count-routers
branch
from
2c1a744 to
27192b1
Compare
|
Ah right, didn't see that in the |
|
thanks a lot. i will tag 2.0.2 with this today. |
|
i now tagged. i wanted to run the tests with php 7.2 too so we can be sure its alright, but unfortunately there is a failure in the dependencies that i have troubles figuring out. phpcr/phpcr-utils#174 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from PHP 7.2,
count(null)yields a warning (see https://3v4l.org/hbmpC).Alternatively
sortedRouterscould be initialized as empty array and trigger a sort if count ofsortedRoutersdiffers fromrouters, but I don't know the exact background of this logic.