Skip to content

Make ChainRouter work with PHP 7.2 #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dkreuer
Copy link

@dkreuer dkreuer commented Sep 28, 2017

Currently the chain router fails in symfony context with

In ChainRouter.php line 101:
                                                                                       
  [Symfony\Component\Debug\Exception\ContextErrorException]                            
  Warning: count(): Parameter must be an array or an object that implements Countable

This is because the sortedRouters property is not initialized.

The change proposes to take the not initialized property into account while fetching all routes.

Currently the chain router fails in symfony context with "Warning: count(): Parameter must be an array or an object that implements Countable" because the sortedRouters property is not initialized.
The change proposes to take the not initialized property into account while fetching all routes.
@dbu
Copy link
Member

dbu commented Sep 28, 2017

this has been fixed in #200 already. i then wanted to actually test that everything works with php 7.2 before tagging a release, but got sidetracked by things not working in one of the phpcr dependencies. (phpcr/phpcr-utils#174 if you are curious). as that problem is not trivial to figure out, and we already claim to be compatible with php 7.2, i will just tag 2.0.2 now as its definitely an improvement.

@dbu dbu closed this Sep 28, 2017
@dbu
Copy link
Member

dbu commented Sep 28, 2017

2.0.2 is now tagged

@dkreuer dkreuer deleted the patch-1 branch September 28, 2017 07:54
@dkreuer
Copy link
Author

dkreuer commented Sep 28, 2017

Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants