Lower Swiftcc by LLVM #371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kateinoigakukun
force-pushed
the
katei/swiftcc-lowering-rebase
branch
2 times, most recently
from
3dfec77 to
a54d888
Compare
kateinoigakukun
force-pushed
the
katei/swiftcc-lowering-rebase
branch
from
a54d888 to
a4814df
Compare
MaxDesiatov
reviewed
Mar 14, 2020
lib/IRGen/GenBuiltin.cpp
Outdated
| call->setAttributes(attrs); | ||
| // Remove swiftself and swifterror attribute to match signature generated from | ||
| // RuntimeFunctions.def. These two parameters are passed using swifterror and swiftself, | ||
| // but the definition of swift_willThrow generated from the def file doesn't has those |
There was a problem hiding this comment.
Suggested change
| // but the definition of swift_willThrow generated from the def file doesn't has those | |
| // but the definition of swift_willThrow generated from the def file doesn't have those |
MaxDesiatov
reviewed
Mar 14, 2020
stdlib/public/runtime/ErrorObject.h
Outdated
| // Notes: | ||
| // Remove swiftself and swifterror attribute to match signature generated from | ||
| // RuntimeFunctions.def. These two parameters are passed using swifterror and swiftself, | ||
| // but the definition of swift_willThrow generated from the def file doesn't has those |
There was a problem hiding this comment.
Suggested change
| // but the definition of swift_willThrow generated from the def file doesn't has those | |
| // but the definition of swift_willThrow generated from the def file doesn't have those |
MaxDesiatov
reviewed
Mar 14, 2020
pull bot
pushed a commit
that referenced
this pull request
May 25, 2021
Revert "Revert "[Build] Make cmark build a build-script product (#371…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on swiftwasm/llvm-project#3 and reviews.llvm.org/D76049
Changes
Revert thin-to-thick forwarder things
As @jckarter said, I changed LLVM to add extra swiftself and swifterror arguments while lowering LLVM IR into WebAssembly binary.
After this change, thin-to-thick forwarder is not necessary anymore, so I reverted #186 .
Actually thin-to-thick forwarder has reference counting bug which causes #331 issue. This new strategy resolves the issue also.
Add
swiftccattribute to runtime functions called from Swift codeAfter the LLVM change, all functions declared in Swift code always has
swiftselfandswifterrorbecause they useswiftcc. But this causes type mismatch while linking because C++ side function declaration didn't haveswiftccattribute.For example,
This Swift function is lowered as
(i32, i32, i32) -> i32function but the C++ side runtime function is lowered as(i32) -> i32. So I addedswiftccattribute to runtime functions linked with Swift using@_silgen_name.