Skip to content

Revert "Revert "[Build] Make cmark build a build-script product (#371… #37608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2021
Merged

Revert "Revert "[Build] Make cmark build a build-script product (#371… #37608

merged 1 commit into from
May 25, 2021

Conversation

drexin
Copy link
Contributor

@drexin drexin commented May 23, 2021

…02)""

This should fix the cmark build to respect cross compilation targets.

@drexin
Copy link
Contributor Author

drexin commented May 23, 2021

@swift-ci please build toolchain

@swift-ci
Copy link
Contributor

Linux Toolchain (Ubuntu 16.04)
Download Toolchain
Git Sha - 3b55e15a3a11b9fa67a1bdbb183311287618c080

Install command
tar zxf swift-PR-37608-598-ubuntu16.04.tar.gz
More info

@drexin drexin force-pushed the wip-build-script-products branch from 3b55e15 to 417402e Compare May 24, 2021 01:44
@drexin
Copy link
Contributor Author

drexin commented May 24, 2021

@swift-ci please build toolchain

@drexin drexin force-pushed the wip-build-script-products branch from 417402e to db362b1 Compare May 24, 2021 02:48
@drexin
Copy link
Contributor Author

drexin commented May 24, 2021

@swift-ci please build toolchain

@drexin drexin force-pushed the wip-build-script-products branch from db362b1 to fabc8cb Compare May 24, 2021 05:17
@drexin
Copy link
Contributor Author

drexin commented May 24, 2021

@swift-ci please build toolchain

@swift-ci
Copy link
Contributor

Linux Toolchain (Ubuntu 16.04)
Download Toolchain
Git Sha - fabc8cb76355401bd11d4453f8d397874ae8aa63

Install command
tar zxf swift-PR-37608-601-ubuntu16.04.tar.gz
More info

@drexin
Copy link
Contributor Author

drexin commented May 24, 2021

@swift-ci build toolchain macos

@drexin drexin force-pushed the wip-build-script-products branch from fabc8cb to 7cfabf5 Compare May 24, 2021 14:03
@drexin
Copy link
Contributor Author

drexin commented May 24, 2021

@swift-ci build toolchain

gottesmm
gottesmm reviewed May 24, 2021
View reviewed changes
utils/swift_build_support/swift_build_support/products/earlyswiftdriver.py
@@ -41,6 +41,9 @@ def is_before_build_script_impl_product(cls):
return True

def should_build(self, host_target):
if self.is_cross_compile_target(host_target):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a follow on commit, can you add a comment here? Also we should ping @artemcm and @nkcsgexi so they know about this.

@swift-ci
Copy link
Contributor

Linux Toolchain (Ubuntu 16.04)
Download Toolchain
Git Sha - 7cfabf5

Install command
tar zxf swift-PR-37608-602-ubuntu16.04.tar.gz
More info

@gottesmm
Copy link
Contributor

@swift-ci smoke test

@drexin
Copy link
Contributor Author

drexin commented May 24, 2021

@swift-ci build toolchain macos

1 similar comment
@drexin
Copy link
Contributor Author

drexin commented May 24, 2021

@swift-ci build toolchain macos

@swift-ci
Copy link
Contributor

macOS Toolchain
Download Toolchain
Git Sha - 7cfabf5

Install command
tar -zxf swift-PR-37608-1000-osx.tar.gz --directory ~/

@gottesmm gottesmm merged commit 63b6232 into swiftlang:main May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gottesmm gottesmm gottesmm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drexin @swift-ci @gottesmm