Re-add support for Symbol objects via JSSymbol#183
Merged
kateinoigakukun merged 6 commits intomainfrom Apr 10, 2022
Merged
Conversation
|
Time Change: +603.75ms (7%) 🔍 Total Time: 8,585.75ms
ℹ️ View Unchanged
|
MaxDesiatov
approved these changes
Apr 9, 2022
Member
|
For the record: https://tc39.es/ecma262/#sec-reflect.get
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This re-adds the functionality removed by #180.
(I accidentally pushed this change to
mainfirst, sorry about that!)The
Reflectnamespace is mainly intended for use withProxyobjects, with each function on that namespace matching the signature of the corresponding proxy trap. For most use cases, normal access is preferable.The test failure was occurring because
Reflect.*functions check that their parameter is really an object. While this is the case for objects, symbols aren’t objects; the[]syntax automatically converts to an object where necessary.