-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-add support for Symbol objects via JSSymbol #183
Conversation
Time Change: +603.75ms (7%) 🔍 Total Time: 8,585.75ms
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
For the record: https://tc39.es/ecma262/#sec-reflect.get
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :)
This re-adds the functionality removed by #180.
(I accidentally pushed this change to
main
first, sorry about that!)The
Reflect
namespace is mainly intended for use withProxy
objects, with each function on that namespace matching the signature of the corresponding proxy trap. For most use cases, normal access is preferable.The test failure was occurring because
Reflect.*
functions check that their parameter is really an object. While this is the case for objects, symbols aren’t objects; the[]
syntax automatically converts to an object where necessary.