Conversation
|
Time Change: +12.75ms (3%) Total Time: 339ms
ℹ️ View Unchanged
|
MaxDesiatov
reviewed
Apr 1, 2022
| public static let split: JSSymbol! = Symbol.split.symbol | ||
| public static let toPrimitive: JSSymbol! = Symbol.toPrimitive.symbol | ||
| public static let toStringTag: JSSymbol! = Symbol.toStringTag.symbol | ||
| public static let unscopables: JSSymbol! = Symbol.unscopables.symbol |
Member
There was a problem hiding this comment.
Wouldn't these be autogenerated from IDL in DOMKit?
Member
Author
There was a problem hiding this comment.
Unfortunately not, as the ECMAScript spec (where these are defined) does not use IDL. (And, technically, it isn’t part of the DOM — it’s a language feature available in Node/Deno/plain JavaScriptCore/etc)
kateinoigakukun
added a commit
that referenced
this pull request
Apr 6, 2022
This reverts commit 081784b.
kateinoigakukun
added a commit
that referenced
this pull request
Apr 6, 2022
This reverts commit 081784b.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
Symboltype, including both properties on theSymbolobject itself and support for accessing Symbol-keyed properties onJSObjectinstances.