Always use xcrun as a fallback for finding binaries on macOS #1998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewbastien
requested review from
0xTim,
adam-fowler and
award999
as code owners
plemarquand
approved these changes
Dec 11, 2025
matthewbastien
force-pushed
the
xcrun-fallback-macos
branch
from
8f038e2 to
38ae0c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The logic added that checks if a binary is managed by
xcrundoes not work if the toolchain is selected via theswift.pathandDEVELOPER_DIRsettings.Unfortunately, without pointing at an xcrun shim directly, the extension cannot possibly know whether or not
swift.pathpoints at an Xcode/CommandLineTools toolchain without using brittle heuristics based on the path. Instead, the extension will now always usexcrunas a fallback on macOS when it can't find a binary within the toolchain path. There could be a case in which a public toolchain is selected and we end up using an Xcode binary, but that should only result from corrupted toolchain installations.Issue: #1077
Tasks
Documentation has been updated