Support updating exsting swiftly installation from swiftly-install.sh #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-server-bot test install please |
|
@swift-server-bot test install please |
|
The test failures look like they're unrelated--the ubuntu 18.04 machine used to run them might be out of disk space or something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #83, also fixes #82
This PR updates the default behavior of swiftly-install.sh when an existing installation exists from prompting to perform a clean installation (i.e. delete all existing configuration and installed toolchains) to simply replacing the swiftly binary. Users can opt into the old behavior (without prompting) by using a newly introduced
--overwriteoption.Going forward, most users will update swiftly via the
self-updatecommand introduced in #81, but since the current released swiftly version doesn't have that command, I think we need to provide a path throughswiftly-install.sh. Furthermore, it would be too easy to accidentally delete your swiftly installation with the old default behavior, given that there isn't another supported means of upgrading.Once this is done, I think I'm good to go ahead with releasing 0.2.0 of swiftly (and 0.3.0 of swiftly-install.sh).