[6.2.1][TypeCheckEffects] AbstractFunction: Parameter types should be mapped… #83954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into context Parameter type could be represented by an associated type which is bound to a concrete type by an extension, `AbstractFunction::getType()` should map it into context before returning because the construct is that it always produces a function type. Resolves: rdar://156955193 (cherry picked from commit 32b97d0) (cherry picked from commit 7f65291)
bnbarham
approved these changes
Aug 27, 2025
Contributor
Author
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… into context
Explanation:
Parameter type could be represented by an associated type which is bound to a concrete type by an extension,
AbstractFunction::getType()should map it into context before returning because the construct is that it always produces a function type.Resolves: rdar://156955193
Main Branch PR: [TypeCheckEffects] AbstractFunction: Parameter types should be mapped… #83687
Risk: Low. This is a very narrow fix that only affects situations when parameter type, represented by an associated type, is bound by an extension.
Reviewed By: @DougGregor
Testing: Added new test-cases to the suite.
(cherry picked from commit 32b97d0) (cherry picked from commit 7f65291)