[TypeCheckEffects] AbstractFunction: Parameter types should be mapped… #83687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into context Parameter type could be represented by an associated type which is bound to a concrete type by an extension, `AbstractFunction::getType()` should map it into context before returning because the construct is that it always produces a function type. Resolves: rdar://156955193
DougGregor
approved these changes
Aug 13, 2025
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test Linux platform |
Contributor
Author
|
@swift-ci please smoke test Linux platform |
Contributor
Author
|
@swift-ci please test Linux platform |
xedin
added a commit
that referenced
this pull request
Aug 28, 2025
… mapped… (#83954) … into context - Explanation: Parameter type could be represented by an associated type which is bound to a concrete type by an extension, `AbstractFunction::getType()` should map it into context before returning because the construct is that it always produces a function type. - Resolves: rdar://156955193 - Main Branch PR: #83687 - Risk: Low. This is a very narrow fix that only affects situations when parameter type, represented by an associated type, is bound by an extension. - Reviewed By: @DougGregor - Testing: Added new test-cases to the suite. (cherry picked from commit 32b97d0) (cherry picked from commit 7f65291) <!-- If this pull request is targeting a release branch, please fill out the following form: https://github.com/swiftlang/.github/blob/main/PULL_REQUEST_TEMPLATE/release.md?plain=1 Otherwise, replace this comment with a description of your changes and rationale. Provide links to external references/discussions if appropriate. If this pull request resolves any GitHub issues, link them like so: Resolves <link to issue>, resolves <link to another issue>. For more information about linking a pull request to an issue, see: https://docs.github.com/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue --> <!-- Before merging this pull request, you must run the Swift continuous integration tests. For information about triggering CI builds via @swift-ci, see: https://github.com/apple/swift/blob/main/docs/ContinuousIntegration.md#swift-ci Thank you for your contribution to Swift! -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… into context
Parameter type could be represented by an associated type which is bound to a concrete type by an extension,
AbstractFunction::getType()should map it into context before returning because the construct is that it always produces a function type.Resolves: rdar://156955193