Serialization: Align conformance recovery logic across compiler modes #83003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always give up early when attempting to deserialize a protocol conformance broken by a context change. Don't attempt to replace missing members of the conformance signature with invalid one, just mark the whole protocol conformance as invalid. The previous recovery logic, only for SourceKit mode and LLDB, was inserting invalid conformances in the signature instead of dropping the whole protocol conformance. It lead to failures later in the same `finishNormalConformance` when accessing the invalid conformances. rdar://98925842
Contributor
Author
|
@swift-ci Please smoke test |
Contributor
Author
|
@swift-ci Please smoke test macOS |
bnbarham
approved these changes
Jul 11, 2025
Contributor
Author
|
@swift-ci Please smoke test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always give up early when attempting to deserialize a protocol conformance broken by a context change. Don't attempt to replace missing members of the conformance signature with invalid one, just mark the whole protocol conformance as invalid.
The previous recovery logic, applied only for SourceKit mode and LLDB, was inserting invalid conformances in the signature instead of dropping the whole protocol conformance. It lead to failures later in the same
finishNormalConformancefunction when matching conformances to requirements.Alternatively we could improve the matching logic, but for now I prefer to align the behavior across the different modes of the compiler. It makes it generally more reliable and testable, at the cost of potentially some information missing in the IDE functionalities when errors are present.
rdar://98925842
Follow-up to #79851