Serialization: Diagnose broken conformances from stale swiftmodule files #79851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a new deserialization mode `enableExtendedDeserializationRecovery` for use when we can afford inconsistent information from a swiftmodule file. It's enabled automatically in debugger mode, when user errors are allowed and during index-while-building.
Failures in `readNormalProtocolConformanceXRef` are usually caused by a dependency change without the required rebuild of its dependents. Display a proper error instead of crashing when encountering such an issue during normal compilation. Recover silently when we can afford to, during indexing or in LLDB.
When deserialization a protocol conformance from a binary swiftmodule file the compiler can encounter inconsistencies caused by stale module files. Replace the hard crash with a proper error and print the list of requirements and conformances being compared to stderr for manual inspection. Recover silently when we can afford to, during indexing or in LLDB.
xymus
requested review from
ahoppen,
bnbarham,
hamishknight,
hborla,
rintaro,
slavapestov and
xedin
as code owners
Contributor
Author
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diagnose failures in
readNormalProtocolConformanceXRefandfinishNormalConformance. These are usually caused by a change in one library without the required rebuild of its dependents, leaving stale swiftmodule files behind.If a single conformance is missing, show an error with the type and protocol and note indirect effects. When there's a mismatch between the number of requirements and the number of conformances found, show an error with the types and list the requirements and conformances to stderr for visual inspection.
Display a proper error instead of crashing when the compiler hit these issues during normal compilation. Or recover silently during indexing or in LLDB. This recovery is gated behind the new
enableExtendedDeserializationRecoverywhich should only be enabled when we can afford reading inconsistent information from swiftmodule files.rdar://125995448&145019988