Skip to content

Discover embedded tests when testing wasmstdlib.py #82376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2025
Merged

Discover embedded tests when testing wasmstdlib.py #82376

merged 1 commit into from
Jun 21, 2025
+1 −1

Conversation

MaxDesiatov
Copy link
Contributor

@MaxDesiatov MaxDesiatov commented Jun 20, 2025 •
edited
Loading

Embedded tests are only included in the build now, a separate change is needed to mark relevant tests as supported.

Without this change:

[2025-06-21T00:53:52.507Z] --- Running tests for wasmstdlib ---
[...]
[2025-06-21T00:59:22.874Z] Total Discovered Tests: 1405
[2025-06-21T00:59:22.874Z]   Excluded         :   2 (0.14%)
[2025-06-21T00:59:22.874Z]   Unsupported      : 725 (51.60%)
[2025-06-21T00:59:22.874Z]   Passed           : 674 (47.97%)
[2025-06-21T00:59:22.874Z]   Expectedly Failed:   4 (0.28%)
[...]
[2025-06-20T17:42:41.045Z] Build Percentage 	 Build Duration (sec) 	 Build Phase
[2025-06-20T17:42:41.045Z] ================ 	 ==================== 	 ===========
[...]
[2025-06-21T02:02:24.048Z] 3.0%              	 324.31                	 Running tests for wasmstdlib

With this change:

[2025-06-20T16:33:58.389Z] --- Running tests for wasmstdlib ---
[...]
[2025-06-20T16:39:29.285Z] Total Discovered Tests: 1626
[2025-06-20T16:39:29.285Z]   Excluded         :   2 (0.12%)
[2025-06-20T16:39:29.285Z]   Unsupported      : 946 (58.18%)
[2025-06-20T16:39:29.285Z]   Passed           : 674 (41.45%)
[2025-06-20T16:39:29.285Z]   Expectedly Failed:   4 (0.25%)
[...]
[2025-06-20T17:42:41.045Z] Build Percentage 	 Build Duration (sec) 	 Build Phase
[2025-06-20T17:42:41.045Z] ================ 	 ==================== 	 ===========
[...]
[2025-06-20T17:42:41.045Z] 3.0%              	 322.87                	 Running tests for wasmstdlib

@MaxDesiatov MaxDesiatov added test suite Area: test suite embedded Embedded Swift WebAssembly Platform: WebAssembly WASI WebAssembly System Interface support labels Jun 20, 2025
@MaxDesiatov
Copy link
Contributor Author

@swift-ci smoke test linux

@MaxDesiatov MaxDesiatov marked this pull request as ready for review June 21, 2025 16:02
@MaxDesiatov MaxDesiatov changed the title Enable all embedded tests in wasmstdlib.py Include all embedded tests in wasmstdlib.py Jun 21, 2025
@MaxDesiatov MaxDesiatov changed the title Include all embedded tests in wasmstdlib.py Discover embedded tests when testing wasmstdlib.py Jun 21, 2025
@MaxDesiatov
Copy link
Contributor Author

@swift-ci smoke test macos

@MaxDesiatov
Copy link
Contributor Author

@swift-ci smoke test windows

@MaxDesiatov MaxDesiatov enabled auto-merge (squash) June 21, 2025 16:07
@MaxDesiatov MaxDesiatov merged commit 9b9db58 into main Jun 21, 2025
3 checks passed
@MaxDesiatov MaxDesiatov deleted the maxd/wasm-embedded_tests branch June 21, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etcwilde etcwilde Awaiting requested review from etcwilde etcwilde is a code owner

@justice-adams-apple justice-adams-apple Awaiting requested review from justice-adams-apple justice-adams-apple is a code owner

@shahmishal shahmishal Awaiting requested review from shahmishal shahmishal is a code owner

@bnbarham bnbarham Awaiting requested review from bnbarham

@kateinoigakukun kateinoigakukun Awaiting requested review from kateinoigakukun

Assignees
No one assigned
Labels
embedded Embedded Swift test suite Area: test suite WASI WebAssembly System Interface support WebAssembly Platform: WebAssembly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MaxDesiatov