Skip to content

Commit 9b9db58

Browse files
authored
Discover embedded tests when testing wasmstdlib.py (#82376)
Embedded tests are only included in test discovery for `wasmstdlib` product, a separate change is needed to mark relevant tests as supported. Without this change: ``` [2025-06-21T00:53:52.507Z] --- Running tests for wasmstdlib --- [...] [2025-06-21T00:59:22.874Z] Total Discovered Tests: 1405 [2025-06-21T00:59:22.874Z] Excluded : 2 (0.14%) [2025-06-21T00:59:22.874Z] Unsupported : 725 (51.60%) [2025-06-21T00:59:22.874Z] Passed : 674 (47.97%) [2025-06-21T00:59:22.874Z] Expectedly Failed: 4 (0.28%) [...] [2025-06-20T17:42:41.045Z] Build Percentage Build Duration (sec) Build Phase [2025-06-20T17:42:41.045Z] ================ ==================== =========== [...] [2025-06-21T02:02:24.048Z] 3.0% 324.31 Running tests for wasmstdlib ``` With this change: ``` [2025-06-20T16:33:58.389Z] --- Running tests for wasmstdlib --- [...] [2025-06-20T16:39:29.285Z] Total Discovered Tests: 1626 [2025-06-20T16:39:29.285Z] Excluded : 2 (0.12%) [2025-06-20T16:39:29.285Z] Unsupported : 946 (58.18%) [2025-06-20T16:39:29.285Z] Passed : 674 (41.45%) [2025-06-20T16:39:29.285Z] Expectedly Failed: 4 (0.25%) [...] [2025-06-20T17:42:41.045Z] Build Percentage Build Duration (sec) Build Phase [2025-06-20T17:42:41.045Z] ================ ==================== =========== [...] [2025-06-20T17:42:41.045Z] 3.0% 322.87 Running tests for wasmstdlib ```
1 parent 374026f commit 9b9db58

File tree

1 file changed

+1
-1
lines changed
  • utils/swift_build_support/swift_build_support/products

1 file changed

+1
-1
lines changed

utils/swift_build_support/swift_build_support/products/wasmstdlib.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ def _build_stdlib(self, host_target, target_triple, llvm_cmake_dir):
179179
# Test configuration
180180
self.cmake_options.define('SWIFT_INCLUDE_TESTS:BOOL', 'TRUE')
181181
self.cmake_options.define('SWIFT_ENABLE_SOURCEKIT_TESTS:BOOL', 'FALSE')
182-
lit_test_paths = ['IRGen', 'stdlib', 'Concurrency/Runtime', 'embedded/wasm']
182+
lit_test_paths = ['IRGen', 'stdlib', 'Concurrency/Runtime', 'embedded']
183183
lit_test_paths = [os.path.join(
184184
self.build_dir, 'test-wasi-wasm32', path) for path in lit_test_paths]
185185
self.cmake_options.define('SWIFT_LIT_TEST_PATHS:STRING',

0 commit comments

Comments
 (0)