[CSFix] SE-0470: Warn about missing @Sendable for unapplied static …
#81345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DougGregor
approved these changes
May 6, 2025
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test Linux platform |
…member references until future Swift version Static member referenced were marked as `@Sendable` by `InferSendableFromCaptures` because metatypes used to be always Sendable which is no longer the case, so in order to maintain the source compatibility we need to downgrade missing `@Sendable` to a warning for unapplied static member references. This affects primarily operators at the moment because other static members form a curry thunk with a call inside and would be diagnosed as a capture. Resolves: rdar://150777469
Contributor
Author
|
@swift-ci please test |
This was referenced May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…member references until future Swift version
Static member referenced were marked as
@SendablebyInferSendableFromCapturesbecause metatypes used to be always Sendable which is no longer the case, so in order to maintain the source compatibility we need to downgrade missing@Sendableto a warning for unapplied static member references.This affects primarily operators at the moment because other static members form a curry thunk with a call inside and would be diagnosed as a capture.
Resolves: rdar://150777469